LPS-95643 #73305

adolfopa · 2019-05-17T12:57:14Z

No description provided.

We need to push the service context so that the service call will not change the modified date.

The set of nested ifs let some cases fall through, without executing the update service method. Move the logic that finds the existing entry to its own method and make sure update is always executed if found.

liferay-continuous-integration · 2019-05-17T12:57:18Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

adolfopa · 2019-05-17T12:57:29Z

ci:test:staging

liferay-continuous-integration · 2019-05-17T13:03:27Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 28 seconds 14 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 57cdc507efc547a6f6a696a27513c74534b5114d

Sender Branch:

Branch Name: LPS-95643
Branch GIT ID: ddccc314afb79d0a4f35a5f610e1e2603876c01d

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-05-17T14:09:31Z

❌ ci:test:relevant - 21 out of 25 jobs passed in 1 hour 10 minutes 12 seconds 13 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 57cdc507efc547a6f6a696a27513c74534b5114d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: bbc7247349e9da411932b58fad6f34c1201a8092

21 out of 25 jobs PASSED

4 Failed Jobs:

21 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

270 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #165734

KBArticleLocalServiceTest.testAddKBArticleWithCustomHTML

org.junit.ComparisonFailure: expected:<...com" target="_blank"[ /]>> but was:<...com" target="_blank"[></a]>>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at com.liferay.knowledge.base.service.test.KBArticleLocalServiceTest.testAddKBArticleWithCustomHTML(KBArticleLocalServiceTest.java:281)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:206)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.TimeoutTestRule$1.evaluate(TimeoutTestRule.java:89)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.liferay.arquillian.extension.ju...

test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #254786

     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:4534: 2 PMD violation(s) were found.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/portlet-configuration/portlet-configuration-web/src/main/java/com/liferay/portlet/configuration/web/internal/display/context/PortletConfigurationPermissionsDisplayContext.java:432 > Avoid unused local variables such as 'restrictPermissionSelectorRoleVisibility'. (PMD Rule: UnusedLocalVariable)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_bestpractices.html#unusedlocalvariable.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/node_modules/portlet-configuration-web/src/main/java/com/liferay/portlet/configuration/web/internal/display/context/PortletConfigurationPermissionsDisplayContext.java:432 > Avoid unused local variables such as 'restrictPermissionSelectorRoleVisibility'. (PMD Rule: UnusedLocalVariable)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_bestpractices.html#unusedlocalvariable.
[beanshell] 
[beanshell] ##
[beanshell] ## git.plugins.properties
[beanshell] ##
[beanshell] 
[beanshell] github.upstream.branch.name=7.0.x
[beanshell] github.sender.branch.sha=df0cfc9fb89051fb25e1765e7849e71978918188
[beanshell] github.receiver.username=liferay
[beanshell] github.sender.branch.name=7.0.x
[beanshell] github.pull.request.number=0
[beanshell] github.upstream.branch.sha=df0cfc9fb89051fb25e1765e7849e71978918188
[beanshell] github.sender.username=liferay
[beanshell] local.git.branch.cached=true
[beanshell] github.origin.name=liferay
[beanshell] 
[beanshell] 
[beanshell] ##
[beanshell] ## git.portal.properties
[beanshell] ##
[beanshell] 
[beanshell] github.upstream.branch.name=master
[beanshell] github.sender.branch.sha=ddccc314afb79d0a4f35a5f610e1e2603876c01d
[beanshell] github.receiver.username=brianchandotcom
[beanshell] github.sender.branch.name=LPS-95643
[beanshell] github.pull.request.number=73305
[beanshell] github.upstream.branch.sha=57cdc507efc547a6f6a696a27513c74534b5114d
[beanshell] github.sender.username=adolfopa
[beanshell] local.git.branch.cached=true
[beanshell] github.origin.name=adolfopa
[beanshell] 
     [echo] WARNING: pmd-jdk8 does not match existing test types (blade-samples,database-upgrade-client,functional,jsf,plugins,portal-startup,service-builder,tck,modules-integration,integration,modules-unit,unit)

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #255182

     [echo] @@ -342,9 +342,8 @@ public class KBArticleLocalServiceUtil {
     [echo]  	}
     [echo]  
     [echo]  	public static com.liferay.knowledge.base.model.KBArticle
     [echo] -			fetchKBArticleByUrlTitle(
     [echo] -				long groupId, String kbFolderUrlTitle, String urlTitle)
     [echo] -		throws com.liferay.portal.kernel.exception.PortalException {
     [echo] +		fetchKBArticleByUrlTitle(
     [echo] +			long groupId, String kbFolderUrlTitle, String urlTitle) {
     [echo]  
     [echo]  		return getService().fetchKBArticleByUrlTitle(
     [echo]  			groupId, kbFolderUrlTitle, urlTitle);
     [echo] diff --git a/modules/apps/knowledge-base/knowledge-base-api/src/main/java/com/liferay/knowledge/base/service/KBArticleLocalServiceWrapper.java b/modules/apps/knowledge-base/knowledge-base-api/src/main/java/com/liferay/knowledge/base/service/KBArticleLocalServiceWrapper.java
     [echo] index 49355cc..8ef31b8 100644
     [echo] --- a/modules/apps/knowledge-base/knowledge-base-api/src/main/java/com/liferay/knowledge/base/service/KBArticleLocalServiceWrapper.java
     [echo] +++ b/modules/apps/knowledge-base/knowledge-base-api/src/main/java/com/liferay/knowledge/base/service/KBArticleLocalServiceWrapper.java
     [echo] @@ -364,8 +364,7 @@ public class KBArticleLocalServiceWrapper
     [echo]  
     [echo]  	@Override
     [echo]  	public com.liferay.knowledge.base.model.KBArticle fetchKBArticleByUrlTitle(
     [echo] -			long groupId, String kbFolderUrlTitle, String urlTitle)
     [echo] -		throws com.liferay.portal.kernel.exception.PortalException {
     [echo] +		long groupId, String kbFolderUrlTitle, String urlTitle) {
     [echo]  
     [echo]  		return _kbArticleLocalService.fetchKBArticleByUrlTitle(
     [echo]  			groupId, kbFolderUrlTitle, urlTitle);
     [echo] .
     [echo] 
     [echo] Detected build services changes. See above build services log for more
     [echo] information. Make sure to commit in all build services results.
      [get] Getting: http://test-1-8/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/255182//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20190517135111406.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20190517135111406.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null720327990.properties

For upstream results, click here.

jpince · 2019-05-17T14:28:47Z

@adolfopa please look into int test failure, I don't see it in upstream.

org.junit.ComparisonFailure: expected:<...com" target="_blank"[ /]>> but was:<...com" target="_blank"[></a]>>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at com.liferay.knowledge.base.service.test.KBArticleLocalServiceTest.testAddKBArticleWithCustomHTML(KBArticleLocalServiceTest.java:281)

cc/ @patriciajeanperez @austinchiang

liferay-continuous-integration · 2019-05-17T14:36:07Z

✔️ ci:test:staging - 14 out of 14 jobs passed in 1 hour 38 minutes 15 seconds 901 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 57cdc507efc547a6f6a696a27513c74534b5114d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: bbc7247349e9da411932b58fad6f34c1201a8092

14 out of 14 jobs PASSED

14 Successful Jobs:

For more details click here.

brianchandotcom · 2019-05-17T17:42:51Z

Merged. Thank you.
View total diff: 22e9417...1a3b71d

adolfopa added 14 commits May 17, 2019 08:44

LPS-95643 Create failing test

f4f4c52

LPS-95643 Make sure dates are consistent

30ae4df

We need to push the service context so that the service call will not change the modified date.

LPS-95643 This is handled by the generated persistence

ded0527

LPS-95643 Handle asset visibility and generate a proper summary

634cdde

LPS-95643 Remove unused code

46af016

LPS-95643 Update dependencies

072bf00

LPS-95643 Make sure we execute update if entry exists

c59d2fa

The set of nested ifs let some cases fall through, without executing the update service method. Move the logic that finds the existing entry to its own method and make sure update is always executed if found.

LPS-95643 SF - Invert conditionals to reduce nesting

d25d789

LPS-95643 Remove duplication

6b2a062

LPS-95643 Invert condition to make both branches symmetrical

68424c5

LPS-95643 Add dependent model to test

22b6ebb

LPS-95643 Write failing test

371ea70

LPS-95643 Make sure parent className/PK are updated correctly

da1d620

LPS-95643 SF

ddccc31

liferay-continuous-integration added ci:test:staging - pending ci:test:relevant - pending ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels May 17, 2019

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels May 17, 2019

liferay-continuous-integration added ci:test:staging - success and removed ci:test:staging - pending labels May 17, 2019

brianchandotcom closed this May 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-95643 #73305

LPS-95643 #73305

adolfopa commented May 17, 2019

liferay-continuous-integration commented May 17, 2019

adolfopa commented May 17, 2019

liferay-continuous-integration commented May 17, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 17, 2019

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

For upstream results, click here.

jpince commented May 17, 2019

liferay-continuous-integration commented May 17, 2019

Base Branch:

Copied in Private Modules Branch:

For more details click here.

brianchandotcom commented May 17, 2019

LPS-95643 #73305

LPS-95643 #73305

Conversation

adolfopa commented May 17, 2019

liferay-continuous-integration commented May 17, 2019

adolfopa commented May 17, 2019

liferay-continuous-integration commented May 17, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 28 seconds 14 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 17, 2019

❌ ci:test:relevant - 21 out of 25 jobs passed in 1 hour 10 minutes 12 seconds 13 ms

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

For upstream results, click here.

jpince commented May 17, 2019

liferay-continuous-integration commented May 17, 2019

✔️ ci:test:staging - 14 out of 14 jobs passed in 1 hour 38 minutes 15 seconds 901 ms

Base Branch:

Copied in Private Modules Branch:

For more details click here.

brianchandotcom commented May 17, 2019