Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-95870 Fix JS transpilation for IE in webpack builds #73439

Closed
wants to merge 3 commits into from
Closed

LPS-95870 Fix JS transpilation for IE in webpack builds #73439

wants to merge 3 commits into from

Conversation

wincent
Copy link

@wincent wincent commented May 21, 2019

No description provided.

@wincent
LPS-95870 Drop unneeded "mode" property from webpack.config.js
b77bbdf 
It is replaced further down by another property.
@wincent
LPS-95870 Order properties
52731d2
@wincent
LPS-95870 Fix JS transpilation for IE in webpack builds
b53a061 
By updating to latest liferay-npm-scripts, which forces the Babel config
to be respected when running wepback as part of the build.
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes 30 seconds 123 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e20d5956a144279ce98555ad8f857268ecd98a5c

Sender Branch:

Branch Name: wincent/LPS-95870/webpack-fix
Branch GIT ID: b53a061aa0327e22458a8d25e4a79fae7e878d0c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 81 out of 94 jobs passed in 1 hour 28 minutes 13 seconds 770 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e20d5956a144279ce98555ad8f857268ecd98a5c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8f4622841cd5220becc7f2f9a0aa1408d5a7db4e

81 out of 94 jobs PASSED

13 Failed Jobs:

81 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at e20d595:
  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
    Job Results:

    6 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #297993
      1. ModulesStructureTest.testScanGradleFiles
        junit.framework.AssertionFailedError: Artifact dependency {compileOnly group: "com.liferay", name: "com.liferay.arquillian.extension.junit.bridge.connector", version: "1.0.0"} in modules/test/arquillian-extension-junit-bridge/build.gradle not permitted on master branch. Use a project dependency instead.
	at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1319)
	at com.liferay.portal.modules.ModulesStructureTest.access$700(ModulesStructureTest.java:66)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:338)
	at com.liferay.portal.modules.ModulesStructureTest$3.visitFile(ModulesStructureTest.java:313)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:311)
  6. ...

@brianchandotcom
Copy link
Owner

Merged. Thx.

@wincent wincent deleted the wincent/LPS-95870/webpack-fix branch June 6, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wincent @liferay-continuous-integration @brianchandotcom