LPS-96625 Not needed

[4lejandrito]

No description provided.

[liferay-continuous-integration]

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 33 seconds 18 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a4a977fe17bdca67073eabfb71de88b8092d593b

Sender Branch:

Branch Name: pr-277
Branch GIT ID: d60a9a6e7475c9e0e38e806bd5a6d343364c0e8a

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

❌ ci:test:relevant - 28 out of 32 jobs passed in 1 hour 25 minutes 11 seconds 362 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 73fa9b927147e5a547a2cce44dd1b46ae9ab390d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1ad4a3697d0bb3ffaa9582b450832f14fda9faa9

28 out of 32 jobs PASSED

4 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4

28 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/5
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/6
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/7
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/8
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/3
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/4
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/5
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/6
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/7
• test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

For more details click here.

---

Failures unique to this pull:

1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

   Job Results:

   16 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #311687

      1. LocalFile.DisplayPages#DeleteDisplayPage - Poshi Report - Poshi Summary - Console Output

---

Failures in common with acceptance upstream results at a4a977f:

1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

   Job Results:

   16 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=1,label_exp=!master #311687

      1. LocalFile.WebContentDisplay#AddWebContent - Poshi Report - Poshi Summary - Console Output

2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3

   Job Results:

   7 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #296948

      1. LocalFile.PGBlogs#SaveBlogsEntryDraft - Poshi Report - Poshi Summary - Console Output

3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/4

   Job Results:

   1 Test Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #319824

      1. LocalFile.WebContentDisplay#AddWithStructure - Poshi Report - Poshi Summary - Console Output

[AliciaGarciaGarcia]

Just started reviewing :)

[brianchandotcom]

Merged. Thank you.
View total diff: 82d9173...79e7216

[brianchandotcom]

Merged and pushed upstream..

@4lejandrito there sure is a lot of duplicate code in here? I wish we could more easily add this to each module without duplicating so much code.

@JorgeFerrer do you mind taking a quick look at how we're doing auto tagging? something seems off.

[JorgeFerrer]

Sure. @4lejandrito <https://github.com/4lejandrito> let's look at this together on Monday

…

Sent from my phone El mié., 12 jun. 2019 22:57, Brian Chan <notifications@github.com> escribió:

Merged and pushed upstream.. @4lejandrito <https://github.com/4lejandrito> there sure is a lot of duplicate code in here? I wish we could more easily add this to each module without duplicating so much code. @JorgeFerrer <https://github.com/JorgeFerrer> do you mind taking a quick look at how we're doing auto tagging? something seems off. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#74419?email_source=notifications&email_token=AAGT5QCRQND32PD32W7V3EDP2FPLNA5CNFSM4HXJALVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRY55I#issuecomment-501452533>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGT5QDDIJBQ5RY55SXVXR3P2FPLNANCNFSM4HXJALVA> .

[JorgeFerrer]

Hey @brianchandotcom ,
I went over this today with @4lejandrito and we both agreed that there is too much duplication. The root cause is that we have to account for all the combination of values of two independent variables: the type of service (GCloud, NLP, ...) and the type of asset (Blog Entry, File Entry, Journal Article). That means that when a new value for any of these variables appears, we have to create N classes (one for each of the values of the other variable).

How do we solve this? We need to change the implementation a bit so that we avoid having to create a class for each point in the matrix. We started writing the solution and have it almost working. The keys are:

1. We will have just one class to implement each type of service. It will be tied to AssetEntry so that the companyId can obtained from it.
2. We will have just one class for each asset type, which is able to extract the text out of it.

We can then have code in one single place which creates all the combination of the two.

We still have one pending challenge though: the configuration. We are currently providing users with an option to enable or disable all possible combinations of the matrix and we want to continue providing that option. To do that, we need to do some improvements to the configuration framework so that it can be more dynamic and show all available options without needing a specific Configuration interface for them. We believe this shouldn't be too hard and Alejandro is going to do some research to find out how to do it.

Makes sense?