LPS-97256 Upgrade only jodd-json dependency on Portal #75996

martamedio · 2019-07-22T17:27:03Z

Hey Brian,

I'm afraid that the changes we've made here #75827 by updating all jodd libraries causes problems and test failures. Please, see:

I've been doing different tests and looks like we can't have unified versions of this libraries throughout the portal without making major changes to our code.

One fast-solution for this issue is just update the jodd-json version on the portal, and let the rest of modules/test continue to use previous versions for the rest of libraries.

cc/ @jpince

This reverts commit aad06b3.

…n go to portal-impl and run "ant format-source-bnd" to auto enforce this" This reverts commit 090deba.

This reverts commit 1c3e112.

liferay-continuous-integration · 2019-07-22T17:27:07Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-07-22T17:30:16Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 59 seconds 509 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e8de67ac0eaa57f1f68907d930a46aebb80ce8da

Sender Branch:

Branch Name: LPS-97256_fix_jodd
Branch GIT ID: a26d56d2be43d63dc451fdceff97c31e4431e10c

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-07-22T18:59:52Z

❌ ci:test:relevant - 42 out of 47 jobs passed in 1 hour 32 minutes 25 seconds 401 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b6d68ffffb5ca46a0f58e5b75e2d4db6b94bb29

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 42f0f00071090eef11549005abdeb1de66de4909

42 out of 47 jobs PASSED

5 Failed Jobs:

42 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 8b6d68f:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #302403
  1. LocalFile.WorkflowCalendar#ApproveEventWithInvitedUser - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/21
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #327862
  1. LocalFile.FormRules#ConfigureAutofillRule - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3
Job Results:
17 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #324179
  1. LocalFile.WorkflowDDL#EditDDLRecordViaMyWorkflowTasks - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

3682 Tests Passed.
92 Tests Failed.

AXIS_VARIABLE=1,label_exp=!master #282970

FileEntryStagedModelDataHandlerTest.testExportsTheVersionAfterDeletingOnStaging

com.liferay.exportimport.kernel.lar.PortletDataException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820112499,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"44418","fileEntryTypeId":"44383","fileName":"0pZINWhU.txt","folderId":"44414","groupId":"44371","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820113326,"mvccVersion":"2","name":"336","readCount":0,"repositoryId":"44371","size":"8","smallImageId":"0","title":"0pZINWhU","treePath":"\/44414\/","userId":"20129","userName":"Test Test","uuid":"a3a1f8b2-a885-c236-3def-5d8466212132","version":"1.1"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820112499,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"44418","fileEntryTypeId":"44383","fileName":"0pZINWhU.txt","folderId":"44414","groupId":"44371","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820113326,"mvccVersion":"3","name":"336","readCount":0,"repositoryId":"44371","size":"8","smallImageId":"0","title":"0pZINWhU","treePath":"\/44414\/","userId":"20129","userName":"Test Test","uuid":"a3a1f8b2-a885-c236-3def-5d8466212132","version":"1.3"}
	at com.liferay.exportimport.kernel.lar.BaseStagedMod...

FolderStagedModelDataHandlerTest.testCleanAssetCategoriesAndTags

com.liferay.exportimport.kernel.lar.PortletDataException: com.liferay.portal.kernel.dao.orm.ORMException: {"companyId":"20100","createDate":1563820125298,"defaultFileEntryTypeId":"45049","description":"pDSxrAfh","folderId":"45056","groupId":"45012","hidden":false,"lastPostDate":1563820125961,"lastPublishDate":null,"modifiedDate":1563820125337,"mountPoint":false,"mvccVersion":"1","name":"6pxJwoM2","parentFolderId":"45041","repositoryId":"45012","restrictionType":1,"status":0,"statusByUserId":"0","statusByUserName":"","statusDate":null,"treePath":"\/45041\/45056\/","userId":"20129","userName":"Test Test","uuid":"1d490bd6-93db-c80b-a06f-ad8cda0450e5"} is stale in comparison to {"companyId":"20100","createDate":1563820125298,"defaultFileEntryTypeId":"0","description":"pDSxrAfh","folderId":"45056","groupId":"45012","hidden":false,"lastPostDate":1563820125961,"lastPublishDate":null,"modifiedDate":1563820125337,"mountPoint":false,"mvccVersion":"2","name":"6pxJwoM2","parentFolderId":"45041","repositoryId":"45012","restrictionType":0,"status":0,"statusByUserId":"0","statusByUserName":"","statusDate":null,"treePath":"\/45041\/45056\/","userId":"20129","userName":"Test Test","uuid":"1d490bd6-93db-c80b-a06f-ad8cda0450e5"}
	at com.liferay.exportimport.kernel.lar.BaseStagedModelDataHandler.importStagedModel(BaseStagedModelDataHandler.java:433)
	at com.liferay.exportimport.kernel.lar.StagedModelDataHandlerUtil.importStagedModel(StagedModelDataHandlerUtil.java:456)
	at com.liferay.exporti...

AXIS_VARIABLE=2,label_exp=!master #282970

DLFileEntryFinderTest.testCountByExtraSettings

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820335478,"custom1ImageId":"0","custom2ImageId":"0","description":"FE3.txt","extension":"txt","extraSettings":"","fileEntryId":"45530","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"45501","groupId":"45496","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820335647,"mvccVersion":"1","name":"248","readCount":0,"repositoryId":"45496","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/45501\/","userId":"20129","userName":"Test Test","uuid":"ea3da45b-2888-8049-6977-1983bc4ed91f","version":"1.1"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820335478,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"45530","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"45501","groupId":"45496","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820335540,"mvccVersion":"2","name":"248","readCount":0,"repositoryId":"45496","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/45501\/","userId":"20129","userName":"Test Test","uuid":"ea3da45b-2888-8049-6977-1983bc4ed91f","version":"1.1"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceI...

DLFileEntryFinderTest.testCountByG_U_F_M_StatusAny

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820336503,"custom1ImageId":"0","custom2ImageId":"0","description":"FE3.txt","extension":"txt","extraSettings":"","fileEntryId":"45607","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"45578","groupId":"45573","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820336698,"mvccVersion":"1","name":"251","readCount":0,"repositoryId":"45573","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/45578\/","userId":"20129","userName":"Test Test","uuid":"fb8b0e0b-e606-36d7-56b2-b021bbc23c41","version":"1.1"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820336503,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"45607","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"45578","groupId":"45573","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820336590,"mvccVersion":"2","name":"251","readCount":0,"repositoryId":"45573","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/45578\/","userId":"20129","userName":"Test Test","uuid":"fb8b0e0b-e606-36d7-56b2-b021bbc23c41","version":"1.1"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceI...

DLFileEntryFinderTest.testCountByG_U_F_M_StatusAnyByMimeType

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820337562,"custom1ImageId":"0","custom2ImageId":"0","description":"FE3.txt","extension":"txt","extraSettings":"","fileEntryId":"45684","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"45655","groupId":"45650","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820337742,"mvccVersion":"1","name":"254","readCount":0,"repositoryId":"45650","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/45655\/","userId":"20129","userName":"Test Test","uuid":"14718fbb-1649-27df-8d44-39f7c3cbab6e","version":"1.1"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820337562,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"txt","extraSettings":"","fileEntryId":"45684","fileEntryTypeId":"0","fileName":"FE3.txt","folderId":"45655","groupId":"45650","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820337631,"mvccVersion":"2","name":"254","readCount":0,"repositoryId":"45650","size":"8","smallImageId":"0","title":"FE3.txt","treePath":"\/45655\/","userId":"20129","userName":"Test Test","uuid":"14718fbb-1649-27df-8d44-39f7c3cbab6e","version":"1.1"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceI...

...

AXIS_VARIABLE=3,label_exp=!master #282970

RepositoryModelUtilTest.testToFileVersions

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820414427,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"","extraSettings":"","fileEntryId":"41364","fileEntryTypeId":"0","fileName":"RxdZ7tn6","folderId":"41360","groupId":"41357","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820414437,"mvccVersion":"0","name":"219","readCount":0,"repositoryId":"41357","size":"8","smallImageId":"0","title":"n9BreFwC","treePath":"\/41360\/","userId":"20129","userName":"Test Test","uuid":"ac85ff20-0b53-151b-bdc2-76b61368e34f","version":"1.0"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"20100","createDate":1563820414427,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"","extraSettings":"","fileEntryId":"41364","fileEntryTypeId":"0","fileName":"RxdZ7tn6","folderId":"41360","groupId":"41357","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820414437,"mvccVersion":"1","name":"219","readCount":0,"repositoryId":"41357","size":"8","smallImageId":"0","title":"CPIO887L","treePath":"\/41360\/","userId":"20129","userName":"Test Test","uuid":"ac85ff20-0b53-151b-bdc2-76b61368e34f","version":"1.0"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.proce...

DLFolderUADAnonymizerTest.testAutoAnonymizeStatusByUserOnly

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"companyId":"20100","createDate":1563820625479,"defaultFileEntryTypeId":"0","description":"NBwXp7Y3","folderId":"53266","groupId":"20123","hidden":false,"lastPostDate":1563820625478,"lastPublishDate":null,"modifiedDate":1563820625522,"mountPoint":false,"mvccVersion":"0","name":"1s40ZSKg","parentFolderId":"0","repositoryId":"20123","restrictionType":0,"status":2,"statusByUserId":"53249","statusByUserName":"diVT33fs jgjHOyqg","statusDate":1563820625518,"treePath":"\/53266\/","userId":"20129","userName":"Test Test","uuid":"d81c427a-85e0-39a5-e86b-e0df8235afb0"} is stale in comparison to {"companyId":"20100","createDate":1563820625479,"defaultFileEntryTypeId":"0","description":"NBwXp7Y3","folderId":"53266","groupId":"20123","hidden":false,"lastPostDate":1563820625478,"lastPublishDate":null,"modifiedDate":1563820625518,"mountPoint":false,"mvccVersion":"1","name":"1s40ZSKg","parentFolderId":"0","repositoryId":"20123","restrictionType":0,"status":2,"statusByUserId":"53258","statusByUserName":"igWHG1mL uJQWCzi2","statusDate":1563820625518,"treePath":"\/53266\/","userId":"20129","userName":"Test Test","uuid":"d81c427a-85e0-39a5-e86b-e0df8235afb0"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.processException(BasePersistenceImpl.java:446)
	at com.liferay.portlet.documentlibrary.service.persistence.impl.DLFolderPersistenceImpl.updateImpl(DLFolderPersiste...

DLFolderUADAnonymizerTest.testAutoAnonymizeUserOnly

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"companyId":"20100","createDate":1563820626062,"defaultFileEntryTypeId":"0","description":"xpat9JPN","folderId":"53296","groupId":"20123","hidden":false,"lastPostDate":1563820626061,"lastPublishDate":null,"modifiedDate":1563820626105,"mountPoint":false,"mvccVersion":"0","name":"bAO2SvQl","parentFolderId":"0","repositoryId":"20123","restrictionType":0,"status":2,"statusByUserId":"20129","statusByUserName":"Test Test","statusDate":1563820626098,"treePath":"\/53296\/","userId":"53279","userName":"mnQGl1se 4wMhAXIg","uuid":"c613a895-7a87-ca68-fed0-d39a50af26c8"} is stale in comparison to {"companyId":"20100","createDate":1563820626062,"defaultFileEntryTypeId":"0","description":"xpat9JPN","folderId":"53296","groupId":"20123","hidden":false,"lastPostDate":1563820626061,"lastPublishDate":null,"modifiedDate":1563820626098,"mountPoint":false,"mvccVersion":"1","name":"bAO2SvQl","parentFolderId":"0","repositoryId":"20123","restrictionType":0,"status":2,"statusByUserId":"20129","statusByUserName":"Test Test","statusDate":1563820626098,"treePath":"\/53296\/","userId":"53288","userName":"OijeUiZq 4LwyAfOe","uuid":"c613a895-7a87-ca68-fed0-d39a50af26c8"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.processException(BasePersistenceImpl.java:446)
	at com.liferay.portlet.documentlibrary.service.persistence.impl.DLFolderPersistenceImpl.updateImpl(DLFolderPersiste...

AXIS_VARIABLE=9,label_exp=!master #282970

WorkflowTaskManagerImplTest.testMovetoTrashAndRestoreFromTrashPendingDLFileEntryInDLFolderWithWorkflow

com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"classNameId":"0","classPK":"0","companyId":"58445","createDate":1563820496612,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"","extraSettings":"","fileEntryId":"59238","fileEntryTypeId":"0","fileName":"aXJHBxIr","folderId":"59232","groupId":"59072","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820499397,"mvccVersion":"3","name":"127","readCount":0,"repositoryId":"59072","size":"8","smallImageId":"0","title":"aXJHBxIr","treePath":"\/59232\/","userId":"59076","userName":"YyMNNtRV RRAyXaTh","uuid":"8794696a-5250-b0c2-3199-e26fcca38f23","version":"1.0"} is stale in comparison to {"classNameId":"0","classPK":"0","companyId":"58445","createDate":1563820496612,"custom1ImageId":"0","custom2ImageId":"0","description":"","extension":"","extraSettings":"","fileEntryId":"59238","fileEntryTypeId":"0","fileName":"aXJHBxIr","folderId":"59232","groupId":"59072","largeImageId":"0","lastPublishDate":null,"manualCheckInRequired":false,"mimeType":"text\/plain","modifiedDate":1563820499383,"mvccVersion":"4","name":"127","readCount":0,"repositoryId":"59072","size":"8","smallImageId":"0","title":"aXJHBxIr","treePath":"\/59232\/","userId":"59076","userName":"YyMNNtRV RRAyXaTh","uuid":"8794696a-5250-b0c2-3199-e26fcca38f23","version":"1.0"}
	at com.liferay.portal.kernel.service.persistence.impl.BasePersi...

brianchandotcom · 2019-07-22T23:35:21Z

Merged. Thx.

Marta Medio added 4 commits July 22, 2019 19:25

Revert "LPS-97256 auto SF"

ef50be3

This reverts commit aad06b3.

Revert "LPS-97256 Modify modules/source-formatter.properties, and the…

cbc1631

…n go to portal-impl and run "ant format-source-bnd" to auto enforce this" This reverts commit 090deba.

Revert "LPS-97256 Upgrade jodd libraries"

e708f35

This reverts commit 1c3e112.

LPS-97256 Upgrade only jodd-json dependency on Portal

a26d56d

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:sf - success and removed ci:test:sf - pending labels Jul 22, 2019

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Jul 22, 2019

brianchandotcom closed this Jul 22, 2019

This was referenced Jul 24, 2019

LPS-97256 Upgrade jodd library martamedio/liferay-portal#92

Closed

LPS-97256 Upgrade only jodd in Portal martamedio/liferay-portal#93

Closed

martamedio deleted the LPS-97256_fix_jodd branch August 20, 2019 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-97256 Upgrade only jodd-json dependency on Portal #75996

LPS-97256 Upgrade only jodd-json dependency on Portal #75996

martamedio commented Jul 22, 2019 •

edited

Loading

liferay-continuous-integration commented Jul 22, 2019

liferay-continuous-integration commented Jul 22, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jul 22, 2019

Base Branch:

Copied in Private Modules Branch:

5 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/21

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

brianchandotcom commented Jul 22, 2019

LPS-97256 Upgrade only jodd-json dependency on Portal #75996

LPS-97256 Upgrade only jodd-json dependency on Portal #75996

Conversation

martamedio commented Jul 22, 2019 • edited Loading

liferay-continuous-integration commented Jul 22, 2019

liferay-continuous-integration commented Jul 22, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 59 seconds 509 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jul 22, 2019

❌ ci:test:relevant - 42 out of 47 jobs passed in 1 hour 32 minutes 25 seconds 401 ms

Base Branch:

Copied in Private Modules Branch:

5 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/21

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

brianchandotcom commented Jul 22, 2019

martamedio commented Jul 22, 2019 •

edited

Loading