Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-98850 Reorder control panel categories #76723

Closed
wants to merge 1 commit into from

Conversation

pei-jung
Copy link

@pei-jung pei-jung commented Aug 7, 2019

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 24 seconds 386 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8c651f1e64737d916464853f440417b4315913a9

Sender Branch:

Branch Name: LPS-98850
Branch GIT ID: cffd9b144dcf32cabc260eb2772b7a4db9fb22a5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 29 seconds 637 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8c651f1e64737d916464853f440417b4315913a9

Sender Branch:

Branch Name: LPS-98850
Branch GIT ID: cffd9b144dcf32cabc260eb2772b7a4db9fb22a5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 1b67fe0...5ee0f6d

@brianchandotcom
Copy link
Owner

@pei-jung I backported the change to modules/apps/product-navigation/product-navigation-control-panel/src/main/java/com/liferay/product/navigation/control/panel/internal/application/list/UsersPanelCategory.java

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:relevant - 17 out of 17 jobs passed in 1 hour 11 minutes 35 seconds 523 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: df0c4a2e1929cf9e9712b49956802b7c8c78effd

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a6af0297523f3e993fe64fd1a16005dc05bf076b

17 out of 17 jobs PASSED
17 Successful Jobs:
For more details click here.

@pei-jung
Copy link
Author

pei-jung commented Aug 7, 2019

Ok, I think that's fine. There were no control panel category with order 100 in 7.1 or 7.2. Maybe there used to be one but got removed. Anyway, backporting the change should be safe and won't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants