LPS-100974 Sets TYPE_DEFAULT as default value instead of NONE #78044

ealonso · 2019-09-06T08:49:43Z

No description provided.

liferay-continuous-integration · 2019-09-06T08:49:48Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-09-06T08:52:48Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 51 seconds 81 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 71745daa8f288050717a83d5cb227449b9b43cc5

Sender Branch:

Branch Name: LPS-100974
Branch GIT ID: fa6146ea7252b2f016ebcd1af49bce030bae1deb

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-09-06T08:58:14Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 27 seconds 738 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 71745daa8f288050717a83d5cb227449b9b43cc5

Sender Branch:

Branch Name: LPS-100974
Branch GIT ID: fa6146ea7252b2f016ebcd1af49bce030bae1deb

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-09-06T10:13:21Z

❌ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 11 minutes 15 seconds 109 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: eb08db0db53def6c1a9e550de1ab62bf9cdc1ea1

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f8544bc9fade1b08c8594e97581f4d2a7dbe24f3

21 out of 23 jobs PASSED

2 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at c062ea2:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

1334 Tests Passed.
6 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #328751

GCloudNaturalLanguageDocumentAssetAutoTaggerTest.testGetTagNamesWithInvalidApiKey

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at com.liferay.asset.auto.tagger.google.cloud.natural.language.test.GCloudNaturalLanguageDocumentAssetAutoTaggerTest.lambda$testGetTagNamesWithInvalidApiKey$1(GCloudNaturalLanguageDocumentAssetAutoTaggerTest.java:75)
	at com.liferay.asset.auto.tagger.google.cloud.natural.language.test.GCloudNaturalLanguageDocumentAssetAutoTaggerTest._testWithGCloudNaturalLanguageAutoTagEntitiesEndpointEnabledAndClassificationEndpointEnabled(GCloudNaturalLanguageDocumentAssetAutoTaggerTest.java:136)
	at com.liferay.asset.auto.tagger.google.cloud.natural.language.test.GCloudNaturalLanguageDocumentAssetAutoTaggerTest.testGetTagNamesWithInvalidApiKey(GCloudNaturalLanguageDocumentAssetAutoTaggerTest.java:65)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:234)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule....

AXIS_VARIABLE=1,label_exp=!master #328751

AssetSearcherStagingTest.testSiteRolePermissions

java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.background.task.internal.messaging.BackgroundTaskMessageListener, message=Unable to execute background task
	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
	at org.apache.log4j.Category.callAppenders(Category.java:206)
	at org.apache.log4j.Category.forcedLog(Category.java:391)
	at org.apache.log4j.Category.log(Category.java:856)
	at com.liferay.portal.log.Log4jLogImpl.error(Log4jLogImpl.java:54)
	at com.liferay.portal.kernel.log.LogWrapper.error(LogWrapper.java:69)
	at com.liferay.portal.background.task.internal.messaging.BackgroundTaskMessageListener.doReceive(BackgroundTaskMessageListener.java:172)
	at com.liferay.portal.kernel.messaging.BaseMessageListener.receive(BaseMessageListener.java:26)
	at com.liferay.portal.kernel.messaging.InvokerMessageListener.receive(InvokerMessageListener.java:74)
	at com.liferay.portal.kernel.messaging.SynchronousDestination.send(SynchronousDestination.java:41)
	at com.liferay.portal.messaging.internal.DefaultMessageBus.sendMessage(DefaultMessageBus.java:309)
	at com.liferay.portal.kernel.messaging.MessageBusUtil.sendMessage(MessageBusUtil.java:82)
	at com.liferay.portal.background.task.service.impl.BackgroundTaskLocalServiceImpl.triggerBackgroundTask(...

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Email test@domain.invalid will be ignored as itis included in mail.send.blacklist
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

AXIS_VARIABLE=2,label_exp=!master #328751

FragmentEntryProcessorFreemarkerTest.testProcessFragmentEntryLinkHTMLWithConfigurationItemSelector

java.lang.AssertionError: {level=ERROR, loggerName=freemarker.runtime, message=Error executing FreeMarker template
	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
	at org.apache.log4j.Category.callAppenders(Category.java:206)
	at org.apache.log4j.Category.forcedLog(Category.java:391)
	at org.apache.log4j.Category.error(Category.java:322)
	at freemarker.log._Log4jLoggerFactory$Log4jLogger.error(_Log4jLoggerFactory.java:60)
	at freemarker.core.Environment.handleTemplateException(Environment.java:834)
	at freemarker.core.Environment.visit(Environment.java:327)
	at freemarker.core.MixedContent.accept(MixedContent.java:54)
	at freemarker.core.Environment.visit(Environment.java:324)
	at freemarker.core.Environment.process(Environment.java:302)
	at freemarker.template.Template.process(Template.java:325)
	at com.liferay.portal.template.freemarker.internal.FreeMarkerTemplate.processTemplate(FreeMarkerTemplate.java:137)
	at com.liferay.portal.template.BaseTemplate.processTemplate(BaseTemplate.java:127)
	at com.liferay.fragment.entry.processor.freemarker.FreeMarkerFragmentEntryProcessor.processFragmentEntryLinkHTML(FreeMarkerFragmentEntryProcessor.java:143)
	at com.liferay.fragment.internal.processor.FragmentEntryProcessorRegistryImpl.processFragmentEntryLinkHTML(F...

FragmentEntryProcessorFreemarkerTest.testProcessFragmentEntryLinkHTMLWithConfigurationItemSelectorNondefaultSegmentId

java.lang.AssertionError: {level=ERROR, loggerName=freemarker.runtime, message=Error executing FreeMarker template
	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
	at org.apache.log4j.Category.callAppenders(Category.java:206)
	at org.apache.log4j.Category.forcedLog(Category.java:391)
	at org.apache.log4j.Category.error(Category.java:322)
	at freemarker.log._Log4jLoggerFactory$Log4jLogger.error(_Log4jLoggerFactory.java:60)
	at freemarker.core.Environment.handleTemplateException(Environment.java:834)
	at freemarker.core.Environment.visit(Environment.java:327)
	at freemarker.core.MixedContent.accept(MixedContent.java:54)
	at freemarker.core.Environment.visit(Environment.java:324)
	at freemarker.core.Environment.process(Environment.java:302)
	at freemarker.template.Template.process(Template.java:325)
	at com.liferay.portal.template.freemarker.internal.FreeMarkerTemplate.processTemplate(FreeMarkerTemplate.java:137)
	at com.liferay.portal.template.BaseTemplate.processTemplate(BaseTemplate.java:127)
	at com.liferay.fragment.entry.processor.freemarker.FreeMarkerFragmentEntryProcessor.processFragmentEntryLinkHTML(FreeMarkerFragmentEntryProcessor.java:143)
	at com.liferay.fragment.internal.processor.FragmentEntryProcessorRegistryImpl.processFragmentEntryLinkHTML(F...

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Error executing FreeMarker template
FreeMarker template error:
The following has evaluated to null or missing:
==> configuration.itemSelector1  [in template "template_id" at line 19, column 16]

Tip: It's the step after the last dot that caused this error, not those before it.
Tip: If the failing expression is known to be legally refer to something that's sometimes null or missing, either specify a default value like myOptionalVar!myDefault, or use [#if myOptionalVar??]when-present[#else]when-missing[/#if]. (These only cover the last step of the expression; to cover the whole expression, use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??

FTL stack trace ("~" means nesting-related):

- Failed at: #if configuration.itemSelector1?is_st...  [in template "template_id" at line 19, column 11]
Java stack trace (for programmers):
freemarker.core.InvalidReferenceException: [... Exception message was already printed; see it above ...]

at freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:131)

at freemarker.core.Expression.assertNonNull(Expression.java:194)

at freemarker.core.BuiltInsForMultipleTypes$is_stringBI._eval(BuiltInsForMultipleTypes.java:401)

at freemarker.core.Expression.eval(Expression.java:78)

at freemarker.core.Expression.evalToBoolean(Expression.java:124)

at freemarker.core.Expression.evalToBoolean(Expression.java:110)

at freemarker.core.IfB...

brianchandotcom · 2019-09-06T21:16:44Z

Merged. Thank you.
View total diff: 75152ed...4205c67

LPS-100974 Sets TYPE_DEFAULT as default value instead of NONE

fa6146e

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Sep 6, 2019

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Sep 6, 2019

liferay-continuous-integration added ci:test:relevant - pending ci:test:relevant - failure and removed ci:test:relevant - pending labels Sep 6, 2019

brianchandotcom closed this Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-100974 Sets TYPE_DEFAULT as default value instead of NONE #78044

LPS-100974 Sets TYPE_DEFAULT as default value instead of NONE #78044

ealonso commented Sep 6, 2019

liferay-continuous-integration commented Sep 6, 2019

liferay-continuous-integration commented Sep 6, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 6, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 6, 2019

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

Tip: It's the step after the last dot that caused this error, not those before it.

FTL stack trace ("~" means nesting-related):
- Failed at: #if configuration.itemSelector1?is_st... [in template "template_id" at line 19, column 11]

Java stack trace (for programmers):

brianchandotcom commented Sep 6, 2019

LPS-100974 Sets TYPE_DEFAULT as default value instead of NONE #78044

LPS-100974 Sets TYPE_DEFAULT as default value instead of NONE #78044

Conversation

ealonso commented Sep 6, 2019

liferay-continuous-integration commented Sep 6, 2019

liferay-continuous-integration commented Sep 6, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 51 seconds 81 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 6, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 27 seconds 738 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 6, 2019

❌ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 11 minutes 15 seconds 109 ms

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

Tip: It's the step after the last dot that caused this error, not those before it.

FTL stack trace ("~" means nesting-related): - Failed at: #if configuration.itemSelector1?is_st... [in template "template_id" at line 19, column 11]

Java stack trace (for programmers):

brianchandotcom commented Sep 6, 2019

FTL stack trace ("~" means nesting-related):
- Failed at: #if configuration.itemSelector1?is_st... [in template "template_id" at line 19, column 11]