Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-101970 Allow to revert minor changes for DS modules too and fix static dependencies #78644

Closed
wants to merge 3 commits into from
Closed

LPS-101970 Allow to revert minor changes for DS modules too and fix static dependencies #78644

wants to merge 3 commits into from

Conversation

achaparro
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 30 seconds 292 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3e128983f69d03f3cf0e352231b44935b297a9ff

Sender Branch:

Branch Name: LPS-101970
Branch GIT ID: 76ee2f92e9b513439309327729609af5a87da732

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@achaparro achaparro changed the title LPS-101970 SF LPS-101970 Allow to revert minor changes for DS modules too and fix static dependencies Sep 20, 2019
@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 47 out of 57 jobs passed in 1 hour 51 minutes 32 seconds 510 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 70f2da48ea1b13794016df044dce38ecdc63ce75

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a330b9b54356c2c725a70ee777305a2b98a16e18

47 out of 57 jobs PASSED
47 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    26 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=18,label_exp=!master #320335

      Please fix semantic versioning on achaparro/LPS-101970

           [exec] 		+   method     isSupportsStringCaseSensitiveQuery()
     [exec] 			+   access     protected
     [exec] 			+   return     boolean
     [exec] 		+   method     isSupportsUpdateWithInnerJoin()
     [exec] 			+   access     protected
     [exec] 			+   return     boolean
     [exec] 		+   method     normalizeName(java.lang.String,java.sql.DatabaseMetaData)
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     runSQL(com.liferay.portal.kernel.dao.db.DBTypeToSQLMap)
     [exec] 			+   return     void
     [exec] 		+   method     runSQL(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     runSQL(java.lang.String[])
     [exec] 			+   return     void
     [exec] 		+   method     runSQL(java.sql.Connection,java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     runSQLTemplate(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     runSQLTemplate(java.lang.String,boolean)
     [exec] 			+   return     void
     [exec] 		+   method     runSQLTemplateString(java.lang.String,boolean,boolean)
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     upgrade()
     [exec] 			+   return     void
     [exec] 		+   method     upgrade(com.liferay.portal.kernel.dao.db.DBProcessContext)
     [exec] 			+   return     void
     [exec] 		+   method     upgrade(com.liferay.portal.kernel.upgrade.UpgradeProcess)
     [exec] 			+   return     void
     [exec] 		+   method     upgrade(java.lang.Class)
     [exec] 			+   return     void
     [exec] 		+   method     upgradeTable(java.lang.String,java.lang.Object[][])
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     upgradeTable(java.lang.String,java.lang.Object[][],java.lang.String,java.lang.String[],com.liferay.portal.kernel.upgrade.util.UpgradeColumn[])
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/4.28.0/7c9cc1c542655afcf77c28bc48f070b511bb8732/com.liferay.portal.kernel-4.28.0.jar

    2. AXIS_VARIABLE=27,label_exp=!master #320335
      1. GroupServiceTest.testGetSiteDefaultInheritLocaleWhenCompanyLocaleModified
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: {"agreedToTermsOfUse":true,"comments":"","companyId":"20097","contactId":"20102","createDate":1568965867479,"defaultUser":true,"emailAddress":"","emailAddressVerified":false,"externalReferenceCode":"","facebookId":"0","failedLoginAttempts":0,"firstName":"","googleUserId":"","graceLoginCount":0,"greeting":"Welcome!","jobTitle":"","languageId":"pt_BR","lastFailedLoginDate":null,"lastLoginDate":null,"lastLoginIP":"","lastName":"","ldapServerId":"0","lockout":false,"lockoutDate":null,"loginDate":1568965867116,"loginIP":"","middleName":"","modifiedDate":1568966318705,"mvccVersion":"0","openId":"","portraitId":"0","reminderQueryAnswer":"","reminderQueryQuestion":"","screenName":"20101","status":0,"timeZoneId":"UTC","userId":"20101","uuid":"39a45340-147a-a3df-1a54-f7495e58749a"} is stale in comparison to {"agreedToTermsOfUse":true,"comments":"","companyId":"20097","contactId":"20102","createDate":1568965867479,"defaultUser":true,"emailAddress":"","emailAddressVerified":false,"externalReferenceCode":"","facebookId":"0","failedLoginAttempts":0,"firstName":"","googleUserId":"","graceLoginCount":0,"greeting":"Welcome!","jobTitle":"","languageId":"en_US","lastFailedLoginDate":null,"lastLoginDate":null,"lastLoginIP":"","lastName":"","ldapServerId":"0","lockout":false,"lockoutDate":null,"loginDate":1568965867116,"loginIP":"","middleName":"","modifiedDate":1568966318743,"mvccVersion":"2",...
Failures in common with acceptance upstream results at 70f2da4:
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3
    Job Results:

    19 Tests Passed.
    8 Tests Failed.

  5. ...

@brianchandotcom
Copy link
Owner

@achaparro I ported this all the way to 7.1.x

See bb717ab 7004758 and d3bbad6

If you want in 7.0.x, please send me a pull.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: d3bbad6...d7f2ebb

@brianchandotcom
Copy link
Owner

Sorry, my earlier comment was for LPS-101810

For LPS-101970, I only ported it to 7.2.x. What about master-private? Do we need a pull there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achaparro @liferay-continuous-integration @brianchandotcom