Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-98640 Build Rest #79231

Closed
wants to merge 2 commits into from
Closed

LPS-98640 Build Rest #79231

wants to merge 2 commits into from

Conversation

epgarcia
Copy link

@epgarcia epgarcia commented Oct 7, 2019

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 30 seconds 148 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e7564ef3fbcdbfa4b0dda5c0bca8b79062d9ffd3

Sender Branch:

Branch Name: pr-977
Branch GIT ID: 85eb3344ef041a343d9b0cff38a94de5dc7371d7

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:relevant - 18 out of 18 jobs passed in 1 hour 4 minutes 41 seconds 46 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 67313d14e94aa2f0d531b4e11658e03a2a65aed7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 020f12be3b7f68e4dcb3356fbd50440b139473fd

18 out of 18 jobs PASSED
18 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

@hhuijser can you and @ling-alan-huang work on this pull and send it back to me? Basically, I'd like to keep the proper order. The way they break it into multiple lines is a good idea. We should come up with a standard line break length. You guys can decide. Thx!

@epgarcia fyi @hhuijser will resend to me. Thx!

@dgarciasarai
Copy link

Thanks @brianchandotcom @hhuijser @ling-alan-huang :)
Let me know when you resend these changes.

@ling-alan-huang
Copy link

I will start to work on this.

@ling-alan-huang
Copy link

Sent SF pull request to Hugo for review: hhuijser#3808

@ling-alan-huang
Copy link

Sent fix on buildREST to Peter for review: petershin#741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants