Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-102794 Adds back basic browser styles for blockquote tags removed by bootstraps _reboot.scss #81443

Closed
wants to merge 2 commits into from
Closed

LPS-102794 Adds back basic browser styles for blockquote tags removed by bootstraps _reboot.scss #81443

wants to merge 2 commits into from

Conversation

adolfopa
Copy link

No description provided.

@adolfopa adolfopa mentioned this pull request Nov 28, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 1 second 401 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a2b1b6ad4cb9c600e63e7239413345f724f07c24

Sender Branch:

Branch Name: pr-1172
Branch GIT ID: 7c8e012e0cedadb3fef208c596557106ad6e4d58

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 20 out of 24 jobs passed in 1 hour 48 minutes 32 seconds 297 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a2b1b6ad4cb9c600e63e7239413345f724f07c24

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1465bf1d0f9a9cdb9c767dedfbb292830ed2661b

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 20 out of 24 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    187 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #300632
      1. ProjectTemplatesTest.testCompareGradlePluginVersions
        org.junit.ComparisonFailure: com.liferay.plugin versions do not match expected:<4.4.[86]> but was:<4.4.[91]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at com.liferay.project.templates.ProjectTemplatesTest.testCompareGradlePluginVersions(ProjectTemplatesTest.java:2826)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.j...
Failures in common with acceptance upstream results at 454faff:
  2. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    716 Tests Passed.
    7 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #360850
      1. components.WidgetsSidebar expands a category on click and closes it when clicking it again
        Invariant Violation: Expected drag drop context
    at invariant (/opt/dev/projects/github/liferay-portal/modules/node_modules/invariant/invariant.js:40:15)
    at Object.useDragDropManager (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/internal/useDragDropManager.js:11:5)
    at Object.useDragSourceMonitor (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/internal/drag.js:10:40)
    at useDrag (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/useDrag.js:17:21)
    at Widget (layout/layout-content-page-editor-web/src/main/resources/META-INF/resources/page_editor/plugins/widgets/components/Widget.js:23:19)
    at renderWithHooks (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:15108:18)
    at mountIndeterminateComponent (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:17342:13)
    at beginWork$1 (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:18486:16)
    at HTMLUnknownElement.callCallback (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:347:14)
    at invokeEventListeners (/opt/dev/projects/github/liferay-portal/modules/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
    at HTMLUnknownElementImpl._dispatch (/opt/dev/projects/github/l...
      2. components.WidgetsSidebar finds a widget when you search it
        Invariant Violation: Expected drag drop context
    at invariant (/opt/dev/projects/github/liferay-portal/modules/node_modules/invariant/invariant.js:40:15)
    at Object.useDragDropManager (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/internal/useDragDropManager.js:11:5)
    at Object.useDragSourceMonitor (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/internal/drag.js:10:40)
    at useDrag (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/useDrag.js:17:21)
    at Widget (layout/layout-content-page-editor-web/src/main/resources/META-INF/resources/page_editor/plugins/widgets/components/Widget.js:23:19)
    at renderWithHooks (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:15108:18)
    at mountIndeterminateComponent (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:17342:13)
    at beginWork$1 (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:18486:16)
    at HTMLUnknownElement.callCallback (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:347:14)
    at invokeEventListeners (/opt/dev/projects/github/liferay-portal/modules/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
    at HTMLUnknownElementImpl._dispatch (/opt/dev/projects/github/l...
      3. components.WidgetsSidebar expands all categories when you type something in search form
        Invariant Violation: Expected drag drop context
    at invariant (/opt/dev/projects/github/liferay-portal/modules/node_modules/invariant/invariant.js:40:15)
    at Object.useDragDropManager (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/internal/useDragDropManager.js:11:5)
    at Object.useDragSourceMonitor (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/internal/drag.js:10:40)
    at useDrag (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dnd/lib/cjs/hooks/useDrag.js:17:21)
    at Widget (layout/layout-content-page-editor-web/src/main/resources/META-INF/resources/page_editor/plugins/widgets/components/Widget.js:23:19)
    at renderWithHooks (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:15108:18)
    at mountIndeterminateComponent (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:17342:13)
    at beginWork$1 (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:18486:16)
    at HTMLUnknownElement.callCallback (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:347:14)
    at invokeEventListeners (/opt/dev/projects/github/liferay-portal/modules/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
    at HTMLUnknownElementImpl._dispatch (/opt/dev/projects/github/l...
      4. ...

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 8e14967...f5af9b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adolfopa @liferay-continuous-integration @brianchandotcom @jbalsas