Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-105826 y property of clientRect is not supported in ie11, so use top when y is not defined #82029

Closed
wants to merge 1 commit into from

Conversation

victorg1991
Copy link

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 11 seconds 598 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 24abb31d547d57577ef044ea0b3bdcaa121f9967

Sender Branch:

Branch Name: LPS-105826
Branch GIT ID: 2ed4ed8e523df4dce8fb872c4061403f575df89e

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 23 out of 26 jobs passed in 1 hour 22 minutes 28 seconds 997 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 24abb31d547d57577ef044ea0b3bdcaa121f9967

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6c0b5322d1e18eac4342d74f6522c7b7a9bbd7ed

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED
23 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 24abb31:
  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #309709

      Please fix semantic versioning on victorg1991/LPS-105826

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec] * com.liferay.trash.kernel.service.persistence       CHANGED    1.1.1      1.1.1      1.1.2      VERSION INCREASE REQUIRED
           [exec] 	~   class      com.liferay.trash.kernel.service.persistence.TrashEntryUtil
           [exec] 		-   annotated  aQute.bnd.annotation.ProviderType
           [exec] 	~   class      com.liferay.trash.kernel.service.persistence.TrashVersionUtil
           [exec] 		-   annotated  aQute.bnd.annotation.ProviderType
           [exec] 	~   interface  com.liferay.trash.kernel.service.persistence.TrashEntryPersistence
           [exec] 		-   annotated  aQute.bnd.annotation.ProviderType
           [exec] 		+   annotated  org.osgi.annotation.versioning.ProviderType
           [exec] 	~   interface  com.liferay.trash.kernel.service.persistence.TrashVersionPersistence
           [exec] 		-   annotated  aQute.bnd.annotation.ProviderType
           [exec] 		+   annotated  org.osgi.annotation.versioning.ProviderType
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/3.82.1/26e0216ed497eaf5dfdf07a33079b4d45be7a5c3/com.liferay.portal.kernel-3.82.1.jar

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: d2cda7b...521b26d

@victorg1991 victorg1991 deleted the LPS-105826 branch January 17, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants