Lps 102798

[shuyangzhou]

No description provided.

[liferay-continuous-integration]

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 52 seconds 987 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9629a5b9066669f06bfc3ad4cd5e5ccb902aa6c0

Sender Branch:

Branch Name: LPS-102798
Branch GIT ID: 4eeea0e086f616adcfd33df3b15b2ad54e9cdf90

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

✔️ ci:test:stable - 8 out of 8 jobs passed

✔️ ci:test:relevant - 17 out of 17 jobs passed in 1 hour 28 minutes 23 seconds 871 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5d166508a99c57e4c60aedc77027b949f91b8431

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f974066a1816a014c2c71d1641a953466a70ec53

ci:test:stable - 8 out of 8 jobs PASSED

8 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/3
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

ci:test:relevant - 17 out of 17 jobs PASSED

17 Successful Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/3
• test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

For more details click here.

[brianchandotcom]

Merged. Thank you.
View total diff: 6351f0b...1a41c65

[brianchandotcom]

@pavel-savinov fyi

[brianchandotcom]

@epgarcia see proper fix from @shuyangzhou

[epgarcia]

Thanks @brianchandotcom and @shuyangzhou for the review. However, I'm afraid that with your fix, the support for non-instanceable portlets in different page experiences was lost (see https://issues.liferay.com/browse/LPS-106351).

[arboliveira]

@epgarcia @pavel-savinov @shuyangzhou Top embedded Search Bar was also affected. Please see my comments here: https://issues.liferay.com/browse/LPS-106351?focusedCommentId=2046798&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2046798 Thanks!