LPS-106021 Assert image src is correct when manipulating the parent #83101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Attention to mocked data, since there aren't any clarification if we gonna still using `getAssetMappingFieldsURL` and `mappingFieldsURL`
Here we are adding a raw preview of the selected value, when the processor calls changedCallback. This is not definitive, as we need to deal with the backend service and the React render process, but still allow us to temporary test processors.
|
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
|
hey @brianchandotcom I needed some commit in your master that are not in Liferay repo for this pr. So I've tried to rebase with your master and removed all commits that mentioned @jpince, let's see if this works :) |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 14 minutes 9 seconds 101 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: pr-139 1 Successful Jobs:For more details click here. |
❌ ci:test:relevant - 0 out of 1 jobs passed in 10 minutes 56 seconds 444 msClick here for more details.Base Branch:Branch Name: master ci:test:relevant - 0 out of 1 jobs PASSED1 Failed Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here. |
|
@victorg1991 rebase error |
|
gonna try again @jpince |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ealonso @p2kmgcl @julien @sandrodw3