LPS-106625 Remove unused action type #83112

sandrodw3 · 2020-01-10T14:29:45Z

No description provided.

**Attention to mocked data, since there aren't any clarification if we gonna still using `getAssetMappingFieldsURL` and `mappingFieldsURL`

…ng things inside Rows

…ike) methods in PageEditor

…for avoid multiple assignments

…mns of a row

…ill be splitted into a RowConfigurationPanel and it's no longer needed too much logic on Frontend for modifications in the number of columns

Number of columns and gutters selectors were shipped from SpacingConfigurationPanel to this new configuration panel

…d moved to new panel

liferay-continuous-integration · 2020-01-10T14:29:52Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

sandrodw3 · 2020-01-10T14:30:21Z

/cc @ealonso @p2kmgcl @victorg1991 @diegonvs

liferay-continuous-integration · 2020-01-10T14:34:28Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 42 seconds 267 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 22bf326c434dfa268f2dff2f45aaf6febe6b38e7

Sender Branch:

Branch Name: LPS-106625-1
Branch GIT ID: a9c2044bbd634c209a6d07fd5a027b73bf61be33

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-01-10T16:32:08Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 44 minutes 53 seconds 782 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1991cde6e2f3ef10689a7b32c819cd91cf9faa55

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 75617d32be4140da10cacdd32360055207640830

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 22 out of 26 jobs PASSED

4 Failed Jobs:

22 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
8 Tests Passed.
5 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #349849
  1. LocalFile.ContentPagesWithSearch#SearchEditableText - Poshi Report - Poshi Summary - Console Output
2. AXIS_VARIABLE=1,label_exp=!master #349849

Failures in common with acceptance upstream results at 1991cde:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
8 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #349849
  1. LocalFile.ContentPagesWithStaging#PublishContentPage - Poshi Report - Poshi Summary - Console Output
  2. LocalFile.ContentPagesWithStagingAndPageTemplates#PublishContentPage - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
4 Tests Passed.
3 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #349749
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #342597
  1. LocalFile.WidgetPagesUseCase#SitesPrivatePagesPermissions - Poshi Report - Poshi Summary - Console Output

brianchandotcom · 2020-01-10T20:17:34Z

@sandrodw3 rebase error, please resend.

ealonso · 2020-01-10T22:44:03Z

Just started reviewing :)

Sent from GH.

sandrodw3 and others added 30 commits January 10, 2020 14:25

LPS-106709 Fix path

403bb76

LPS-106709 Fix buttons order

c968129

LPS-106031 Creates MapConfigurationPanel

96420cc

**Attention to mocked data, since there aren't any clarification if we gonna still using `getAssetMappingFieldsURL` and `mappingFieldsURL`

LPS-106031 Move FieldsService methods to AssetService

e4eeeb9

LPS-106031 Move openInfoItemSelector and reuse

963c1d5

LPS-106031 Fix jsdocs

19db633

LPS-106031 Rename AssetService to InfoItemService

66bf78b

LPS-106031 Rename AssetSelectionPanel to InfoItemSelectionPanel

2a823df

LPS-106627 Rename FallbackEditor functions

4cd6659

LPS-106627 Add tests for FallbackProcessor

6b83e5c

LPS-106828 We should also modify the numberOfColumns

3d26c48

LPS-106828 Prevent errors

a793fef

LPS-106828 Also return the deleted fragment entry link ids

e483589

LPS-106828 Update js call

888149d

LPS-106828 Update tests

e5e26df

LPS-106828 Update logic

a5597d1

LPS-106753 Removes no needed updateLayoutData

228fe77

LPS-105631 Adds createColumn and removeColumn actions for modifyi…

7f9e1db

…ng things inside Rows

LPS-105631 Uses createColumn and removeColumn as push pop(stack-l…

c1daf68

…ike) methods in PageEditor

LPS-105631 Typo

59b9f8e

LPS-105631 Compose redux destructuring with updateColumnsSize call …

5502497

…for avoid multiple assignments

LPS-105631 Added thunk and service to update an item's config

ba965b7

LPS-105631 Updated calls to updateItemConfig

c390ec7

LPS-105631 Added type, thunk and service to update the number of colu…

01d9a99

…mns of a row

LPS-105631 Removes unnecessary code since SpacingConfigurationPanel w…

a74f5cd

…ill be splitted into a RowConfigurationPanel and it's no longer needed too much logic on Frontend for modifications in the number of columns

LPS-105631 Set the default value of number of columns as 3

aba6de6

LPS-105631 Adds RowConfigurationPanel

b628c21

Number of columns and gutters selectors were shipped from SpacingConfigurationPanel to this new configuration panel

LPS-105631 No needed

893e859

LPS-105631 Apply gutters correctly

12d64b9

LPS-105631 Translate

b9aff9b

sandrodw3 added 13 commits January 10, 2020 14:25

LPS-105631 buildLang

fd5ad11

LPS-105631 Fix checked property

f006535

LPS-106625 Use selector for getting segmentsExperienceId

1290dc3

LPS-106625 Added onClear to ColorPalette component

3ba0074

LPS-106625 Container configuration options separated in components an…

5959217

…d moved to new panel

LPS-106625 Container background color configuration moved to new panel

44aa5a6

LPS-106625 Container background image configuration moved to new panel

a8b1551

LPS-106625 Remove extra class

023b4ed

LPS-106625 Correct columns borders

fb259de

LPS-106625 Remove unused action

79b5040

LPS-106625 Renaming

c388bcc

LPS-106625 Set gutters to true by default

012b4a4

LPS-106625 Remove unused action type

a9c2044

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 10, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jan 10, 2020

brianchandotcom closed this Jan 10, 2020

sandrodw3 deleted the LPS-106625-1 branch March 10, 2020 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-106625 Remove unused action type #83112

LPS-106625 Remove unused action type #83112

sandrodw3 commented Jan 10, 2020

liferay-continuous-integration commented Jan 10, 2020

sandrodw3 commented Jan 10, 2020

liferay-continuous-integration commented Jan 10, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 10, 2020

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

brianchandotcom commented Jan 10, 2020

ealonso commented Jan 10, 2020

LPS-106625 Remove unused action type #83112

LPS-106625 Remove unused action type #83112

Conversation

sandrodw3 commented Jan 10, 2020

liferay-continuous-integration commented Jan 10, 2020

sandrodw3 commented Jan 10, 2020

liferay-continuous-integration commented Jan 10, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 42 seconds 267 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 10, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 44 minutes 53 seconds 782 ms

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

brianchandotcom commented Jan 10, 2020

ealonso commented Jan 10, 2020