LPS-98387 check OAuth2 permissions #83500

javiergamarra · 2020-01-19T19:28:07Z

Waiting for all the tests

liferay-continuous-integration · 2020-01-19T19:28:14Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2020-01-19T19:36:39Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 48 seconds 6 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 57b042241764610e5faca96b11fff0715d9f0ba9

Sender Branch:

Branch Name: LPS-98387_permissions_oauth
Branch GIT ID: 9a3fbd075891a6ddf5fa71edeb38f8c0e98758eb

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-01-20T00:52:40Z

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 30 out of 35 jobs passed in 5 hours 15 minutes 34 seconds 244 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c7627b6aa41e2292f53e9e7d26cdd361fdbfcfc3

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b48e22ed1129b772ad8bdbb965fb3eccc584f484

ci:test:stable - 8 out of 9 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8~~

8 Successful Jobs:

ci:test:relevant - 30 out of 35 jobs PASSED

5 Failed Jobs:

30 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #354165

Please fix semantic versioning on nhpatt/LPS-98387_permissions_oauth

     [exec] > Task :apps:portal-vulcan:portal-vulcan-impl:autoUpdateXml SKIPPED
     [exec] > Task :apps:portal-vulcan:portal-vulcan-impl:baseline SKIPPED
     [exec] > Task :apps:portal-vulcan:portal-vulcan-impl:syncVersions
     [exec] 
     [exec] > Task :apps:app-builder:app-builder-web:packageRunBuild
     [exec] Bundling took 27s
     [exec] Done in 34.66s.
     [exec] 
     [exec] > Task :apps:app-builder:app-builder-web:compileJava
     [exec] 
     [exec] > Task :apps:app-builder:app-builder-web:copyLibs SKIPPED
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/app-builder/app-builder-web/src/main/java/com/liferay/app/builder/web/internal/application/list/ProductMenuPanelApp.java uses or overrides a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] > Task :apps:app-builder:app-builder-web:processResources
     [exec] > Task :apps:app-builder:app-builder-web:replaceSoyTranslation SKIPPED
     [exec] > Task :apps:app-builder:app-builder-web:wrapSoyAlloyTemplate SKIPPED
     [exec] > Task :apps:app-builder:app-builder-web:classes
     [exec] 
     [exec] > Task :apps:app-builder:app-builder-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:app-builder:app-builder-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.17/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] 
     [exec] > Task :apps:app-builder:app-builder-web:compileJSP
     [exec] > Task :apps:app-builder:app-builder-web:zipZippableResources UP-TO-DATE
     [exec] > Task :apps:app-builder:app-builder-web:jar
     [exec] > Task :apps:app-builder:app-builder-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:app-builder:app-builder-web:baseline SKIPPED
     [exec] > Task :apps:app-builder:app-builder-web:syncVersions
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:portal-vulcan:portal-vulcan-api:baseline'.
     [exec] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.portal.vulcan.api-4.1.2.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.portal.vulcan.api/4.1.1/be466a438cc9d82e4c50f98f3ff4436499dec276/com.liferay.portal.vulcan.api-4.1.1.jar

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #354166

Startup error: Unresolved Requirement(s)

     [exec] 22:41:44,809 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED com.liferay.document.library.repository.external.api_4.0.2 [154]
     [exec] 22:41:44,809 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED com.liferay.document.library.sync.api_3.0.1 [155]
     [exec] 22:41:44,810 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED Liferay Foundation - Liferay Hypermedia REST APIs - SPI_1.0.0 [157]
     [exec] 22:41:44,814 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED Liferay Foundation - Liferay Portal Portlet Bridge - API_1.0.0 [159]
     [exec] 22:41:44,815 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED com.liferay.portal.portlet.bridge.soy.api_3.0.1 [160]
     [exec] 22:41:44,815 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED Liferay Foundation - Liferay External Reference - Impl_1.0.0 [161]
     [exec] 22:41:44,820 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED com.liferay.external.reference.service_3.0.1 [162]
     [exec] 22:41:44,821 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED Liferay Collaboration - Liferay Knowledge Base - Impl_1.0.0 [163]
     [exec] 22:41:44,829 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED com.liferay.knowledge.base.editor.configuration_4.0.1 [164]
     [exec] 22:41:44,844 DEBUG [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][BundleStartStopLogger:48] STARTED com.liferay.knowledge.base.markdown.converter.impl_3.0.1 [166]
     [exec] 22:41:44,854 INFO  [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][UpgradeProcess:93] Upgrading com.liferay.knowledge.base.internal.activator.KnowledgeBaseServiceBundleActivator$1
     [exec] 22:41:44,940 INFO  [Start Level: Equinox Container: ccf8f381-88ef-4823-8c5e-d0bd7c35440e][UpgradeProcess:107] Completed upgrade process com.liferay.knowledge.base.internal.activator.KnowledgeBaseServiceBundleActivator$1 in 86 ms

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

1451 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=5,label_exp=!master #299987

MetricResourceTest.testGetProcessMetric

java.lang.AssertionError: {"histograms": [{"key": "2020-01-20T00:00", "value": 1.0}], "value": Infinity} does not equal {"histograms": [{"key": "2020-01-20T00:00", "value": 0.0}], "value": NaN}
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at com.liferay.portal.workflow.metrics.rest.resource.v1_0.test.BaseMetricResourceTestCase.assertEquals(BaseMetricResourceTestCase.java:202)
	at com.liferay.portal.workflow.metrics.rest.resource.v1_0.test.MetricResourceTest._assertMetric(MetricResourceTest.java:147)
	at com.liferay.portal.workflow.metrics.rest.resource.v1_0.test.MetricResourceTest._testGetProcessMetric(MetricResourceTest.java:222)
	at com.liferay.portal.workflow.metrics.rest.resource.v1_0.test.MetricResourceTest.testGetProcessMetric(MetricResourceTest.java:116)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:234)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.lifera...

Failures in common with acceptance upstream results at c7627b6:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

210 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #352314

ProjectTemplateFilesTest.testProjectTemplateFiles

org.junit.ComparisonFailure: Forbidden leading or trailing whitespaces in ../project-templates-npm-vuejs-portlet/src/main/resources/archetype-resources/.babelrc.js expected:<...presets": ["env"]
};[]> but was:<...presets": ["env"]
};[
]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:926)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:951)
	at com.liferay.project.templates.ProjectTemplateFilesTest.access$400(ProjectTemplateFilesTest.java:70)
	at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:895)
	at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:840)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testProjectTemplateFiles(ProjectTemplateFilesTest.java:838)
	at com.liferay.project.templates.ProjectTemplateFilesTest.testProjectTemplateFiles(ProjectTemplateFilesTest.java:84)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMeth...

brianchandotcom · 2020-01-20T06:44:31Z

@nhpatt I backported this to 7.1.x and 7.2.x.

Can you send me a follow up pull and fix the deprecation info in dca57ea

Run the following command to see why I am throwing an exception

git grep -A 3 "throw new UnsupportedOperationException" **ServiceImpl.java

javiergamarra added 7 commits January 19, 2020 14:04

LPS-104324 add real validation

41217ca

LPS-98387 add scope checker

6958c56

LPS-98387 propagate scopeChecker value

ce74ffa

LPS-98387 add missing dependencies

ce4a995

LPS-98387 change generation to add ScopeChecker

98249ce

LPS-98387 add null check

b199062

LPS-98387 generate

9a3fbd0

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 19, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Jan 19, 2020

javiergamarra closed this Jan 20, 2020

javiergamarra deleted the LPS-98387_permissions_oauth branch January 20, 2020 06:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-98387 check OAuth2 permissions #83500

LPS-98387 check OAuth2 permissions #83500

javiergamarra commented Jan 19, 2020 •

edited

Loading

liferay-continuous-integration commented Jan 19, 2020

liferay-continuous-integration commented Jan 19, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 20, 2020

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

brianchandotcom commented Jan 20, 2020

LPS-98387 check OAuth2 permissions #83500

LPS-98387 check OAuth2 permissions #83500

Conversation

javiergamarra commented Jan 19, 2020 • edited Loading

liferay-continuous-integration commented Jan 19, 2020

liferay-continuous-integration commented Jan 19, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 48 seconds 6 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 20, 2020

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 30 out of 35 jobs passed in 5 hours 15 minutes 34 seconds 244 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

brianchandotcom commented Jan 20, 2020

javiergamarra commented Jan 19, 2020 •

edited

Loading