Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-107465 Adds log debug #83683

Closed
wants to merge 1 commit into from
Closed

LPS-107465 Adds log debug #83683

wants to merge 1 commit into from

Conversation

ealonso
Copy link

@ealonso ealonso commented Jan 23, 2020

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 55 seconds 210 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cccefd5d2542922258d2a9722c7a092b97575bb3

Sender Branch:

Branch Name: LPS-107465
Branch GIT ID: 53fe29d12c023e91bccaf91dcc84095ba5f31b66

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 28 minutes 41 seconds 315 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: be52b29ab6dc3ec2fdf212de2fbd549545123280

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 675fd6f1716b42f77cc332cad8893e473d800091

ci:test:stable - 8 out of 9 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at c4beacb:
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    795 Tests Passed.
    6 Tests Failed.

    1. AXIS_VARIABLE=2,label_exp=!master #248904
      1. LayoutConverterTest.testConvertOneColumnMultiplePortlets
        java.lang.NullPointerException
	at com.liferay.portal.kernel.portlet.PortletIdCodec.decodePortletName(PortletIdCodec.java:48)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.fetchPortletById(PortletLocalServiceImpl.java:405)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.getPortletById(PortletLocalServiceImpl.java:523)
	at sun.reflect.GeneratedMethodAccessor174.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
	at com.sun.proxy.$Proxy26.getPortletById(Unknown Source)
	at com.liferay.portal.kernel.service.PortletLocalServiceUtil.getPortletById(PortletLocalServiceUtil.java:362)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:764)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:548)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:538)
	at com.liferay.portal.kernel.portlet.PortletPreferencesFactoryUtil.getPortletSetup(PortletPreferencesFactoryUtil.java:195)
	at com.liferay.layout.test.util.LayoutTestUtil.getPortletPreferences(LayoutTestUtil.java:350)
	at com.liferay.layout.test.util....
      2. LayoutConverterTest.testConvertThreeColumnsMultiplePortlets
        java.lang.NullPointerException
	at com.liferay.portal.kernel.portlet.PortletIdCodec.decodePortletName(PortletIdCodec.java:48)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.fetchPortletById(PortletLocalServiceImpl.java:405)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.getPortletById(PortletLocalServiceImpl.java:523)
	at sun.reflect.GeneratedMethodAccessor174.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
	at com.sun.proxy.$Proxy26.getPortletById(Unknown Source)
	at com.liferay.portal.kernel.service.PortletLocalServiceUtil.getPortletById(PortletLocalServiceUtil.java:362)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:764)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:548)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:538)
	at com.liferay.portal.kernel.portlet.PortletPreferencesFactoryUtil.getPortletSetup(PortletPreferencesFactoryUtil.java:195)
	at com.liferay.layout.test.util.LayoutTestUtil.getPortletPreferences(LayoutTestUtil.java:350)
	at com.liferay.layout.test.util....
      3. LayoutConverterTest.testConvertThreeColumnsSinglePortlet
        java.lang.NullPointerException
	at com.liferay.portal.kernel.portlet.PortletIdCodec.decodePortletName(PortletIdCodec.java:48)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.fetchPortletById(PortletLocalServiceImpl.java:405)
	at com.liferay.portal.service.impl.PortletLocalServiceImpl.getPortletById(PortletLocalServiceImpl.java:523)
	at sun.reflect.GeneratedMethodAccessor174.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
	at com.sun.proxy.$Proxy26.getPortletById(Unknown Source)
	at com.liferay.portal.kernel.service.PortletLocalServiceUtil.getPortletById(PortletLocalServiceUtil.java:362)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:764)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:548)
	at com.liferay.portlet.PortletPreferencesFactoryImpl.getPortletSetup(PortletPreferencesFactoryImpl.java:538)
	at com.liferay.portal.kernel.portlet.PortletPreferencesFactoryUtil.getPortletSetup(PortletPreferencesFactoryUtil.java:195)
	at com.liferay.layout.test.util.LayoutTestUtil.getPortletPreferences(LayoutTestUtil.java:350)
	at com.liferay.layout.test.util....
      4. ...
  3. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    210 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #316888
      1. ProjectTemplateFilesTest.testProjectTemplateFiles
        org.junit.ComparisonFailure: Forbidden leading or trailing whitespaces in ../project-templates-npm-react-portlet/src/main/resources/archetype-resources/.babelrc.js expected:<... ["env", "react"]
};[]> but was:<... ["env", "react"]
};[
]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:926)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:951)
	at com.liferay.project.templates.ProjectTemplateFilesTest.access$400(ProjectTemplateFilesTest.java:70)
	at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:895)
	at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:840)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.project.templates.ProjectTemplateFilesTest._testProjectTemplateFiles(ProjectTemplateFilesTest.java:838)
	at com.liferay.project.templates.ProjectTemplateFilesTest.testProjectTemplateFiles(ProjectTemplateFilesTest.java:84)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMeth...

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 2c3f64c...5c2199c

@brianchandotcom
Copy link
Owner

@hhuijser please enforce this.. no swallowed exceptions allowed

@ealonso you missed this one 253ab24 (same class)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ealonso @liferay-continuous-integration @brianchandotcom