Lps 107396 #85277

shuyangzhou · 2020-02-25T23:37:07Z

No description provided.

…it in the query

…statements in the same line

…e condition in the same statement

…ndition when the column already has that condition

… way we accept templates with semicolon

… added for Hypersonic

…n name is confusing

liferay-continuous-integration · 2020-02-25T23:37:13Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2020-02-25T23:47:42Z

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes 42 seconds 207 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5d592244468cdd73ab15be4d68202ec9a6aac35f

Sender Branch:

Branch Name: LPS-107396
Branch GIT ID: 7f376d8e358b8fdd40b45eb420144e1cd394c23a

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: Rename variable '_isNullable' to '_nullable': ./modules/dxp/apps/portal/portal-dao-db/src/test/java/com/liferay/portal/dao/db/OracleDBTest.java 104 (Checkstyle:VariableNameCheck)
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:438)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:266)
[stopwatch] [run.batch.test.action: 1:28.877 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:693: Java returned: 1
      [get] Getting: http://test-1-7/job/test-portal-source-format/2105//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20200225154727960.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20200225154727960.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1679879198.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null449050838

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 254ms

[junitreport] Deleting: /tmp/null449050838

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 02-25-2020 15:47:32:699 PST

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[echo]

[echo] Ant GC log:

[echo]

[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)

[echo] Memory: 4k page, physical 32902104k(2966784k free), swap 0k(0k free)

brianchandotcom · 2020-02-25T23:54:32Z

@shuyangzhou @achaparro SF, please resend.

shuyangzhou · 2020-02-26T00:05:49Z

Resent at #85284

liferay-continuous-integration · 2020-02-26T02:36:07Z

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 118 out of 125 jobs passed in 2 hours 57 minutes 58 seconds 93 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cd88252c3891fd40e757e2c658ef6c1c7b257f9a

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 369adaa554df99e553e5e33a7f5457e8101dc3f1

ci:test:stable - 10 out of 11 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/unit-jdk8~~

10 Successful Jobs:

ci:test:relevant - 118 out of 125 jobs PASSED

7 Failed Jobs:

118 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/54
Job Results:
12 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #117349
  1. LocalFile.AppBuilder#CreateRemoveUpdateDeleteEntriesOfStandaloneApp - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55
Job Results:
1 Test Passed.
6 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #339128
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/76
Job Results:
21 Tests Passed.
5 Tests Failed.
1. AXIS_VARIABLE=2,label_exp=!master #326729
2. AXIS_VARIABLE=3,label_exp=!master #326729
  1. LocalFile.ContentPagesWithFragmentConfiguration#AddTextConfigurationFragmentToContentPage - Poshi Report - Poshi Summary - Console Output
  2. LocalFile.ContentPagesWithSearch#SearchStaticText - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/77
Job Results:
2 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #294548
  Build was aborted
2. AXIS_VARIABLE=1,label_exp=!master #294548
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/80
Job Results:
23 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #362135
  1. LocalFile.WorkflowWebContent#EditWebContentInReviewProcess - Poshi Report - Poshi Summary - Console Output
...

achaparro and others added 23 commits February 25, 2020 10:34

LPS-107396 If we don't add null or not null we don't have to include …

d50c100

…it in the query

LPS-107396 Add nullable clause in those databases which allow it

7de22dc

LPS-107396 Add it in two commands for Postgres

f64d257

LPS-107396 Implementation for DB2. DB2 does not allow to execute two …

8b197d4

…statements in the same line

LPS-107396 Postgres does not allow to change the type and the nullabl…

372806c

…e condition in the same statement

LPS-107396 Oracle throws an error if we try to change the nullable co…

d54452f

…ndition when the column already has that condition

LPS-107396 SQLServer returns NVARCHAR for Varchar, string o text types

750d7f5

LPS-107396 I think we do not need this anymore

7ac5a2e

LPS-107396 Take into account the case when nullable is blank

9c09da7

LPS-107396 New integration tests

770990d

LPS-107396 Null is always the last word when we have 5 words. In this…

7f897f3

… way we accept templates with semicolon

LPS-107396 Now we need to validate if the nullable condition has been…

de60548

… added for Hypersonic

LPS-107396 New unit tests for reword with every database and DBInspector

d036ad9

LPS-107396 Use another column instead of name since alter table colum…

98615dd

…n name is confusing

LPS-107396 Use CharPool

66eba13

LPS-107396 Less String chopping

5822a7a

LPS-107396 Fix test class name

0a30ddb

LPS-107396 Implement a more generic logic for DB2

c18eee5

LPS-107396 Throw SQLException where buildSQL is used

2533612

LPS-107396 SQLException is allowed now

b182892

LPS-107396 Proper assert

7a77119

LPS-107396 Make it test friendly

4180b47

LPS-107396 Avoid powermock

7f376d8

shuyangzhou mentioned this pull request Feb 25, 2020

LPS-107396 Alter column type: support modifying nullable condition shuyangzhou/liferay-portal#8882

Closed

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - pending labels Feb 25, 2020

brianchandotcom closed this Feb 25, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lps 107396 #85277

Lps 107396 #85277

shuyangzhou commented Feb 25, 2020

liferay-continuous-integration commented Feb 25, 2020

liferay-continuous-integration commented Feb 25, 2020

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

brianchandotcom commented Feb 25, 2020

shuyangzhou commented Feb 26, 2020

liferay-continuous-integration commented Feb 26, 2020

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/54

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/76

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/77

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/80

Job Results:

Lps 107396 #85277

Lps 107396 #85277

Conversation

shuyangzhou commented Feb 25, 2020

liferay-continuous-integration commented Feb 25, 2020

liferay-continuous-integration commented Feb 25, 2020

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes 42 seconds 207 ms

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

brianchandotcom commented Feb 25, 2020

shuyangzhou commented Feb 26, 2020

liferay-continuous-integration commented Feb 26, 2020

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 118 out of 125 jobs passed in 2 hours 57 minutes 58 seconds 93 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/54

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/76

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/77

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/80

Job Results: