Lps 107396 #85284

shuyangzhou · 2020-02-26T00:05:37Z

No description provided.

…it in the query

…statements in the same line

…e condition in the same statement

…ndition when the column already has that condition

… way we accept templates with semicolon

… added for Hypersonic

…n name is confusing

liferay-continuous-integration · 2020-02-26T00:05:43Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2020-02-26T00:09:53Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 21 seconds 259 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 25522c49c4620eb320ab22ca9deecf70b23cb92e

Sender Branch:

Branch Name: LPS-107396
Branch GIT ID: eabdcfdf170e9e351db43a2d9af5c5e22da0d5f4

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-02-26T03:28:40Z

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 117 out of 125 jobs passed in 3 hours 14 minutes 57 seconds 927 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cd88252c3891fd40e757e2c658ef6c1c7b257f9a

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 369adaa554df99e553e5e33a7f5457e8101dc3f1

ci:test:stable - 10 out of 11 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/unit-jdk8~~

10 Successful Jobs:

ci:test:relevant - 117 out of 125 jobs PASSED

8 Failed Jobs:

117 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/35
Job Results:
4 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #258146
  1. LocalFile.ApplicationDisplayTemplatesUseCase#AddRSSADTViaPortletConfiguration - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55
Job Results:
1 Test Passed.
6 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #325315

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/64

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #325314

     [exec] * What went wrong:
     [exec] Execution failed for task ':writePoshiProperties'.
     [exec] > Process 'command '/opt/java/jdk1.8.0_121-x64/bin/java'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Get more help at https://help.gradle.org
     [exec] 
     [exec] BUILD FAILED in 22s
     [exec] 1 actionable task: 1 executed
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2020-02-25-17-50-12.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] Result: 1
[stopwatch] [run.batch.test.action: 1:03.559 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:361: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1485: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1489: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:24: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:11205: Warning: Could not find file /opt/dev/projects/github/liferay-portal/portal-web/test.generated.properties to copy.
      [get] Getting: http://test-1-8/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/325314//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20200225175034191.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20200225175034191.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null741640514.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null204758145

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 226ms

[junitreport] Deleting: /tmp/null204758145

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/76
Job Results:
21 Tests Passed.
5 Tests Failed.
1. AXIS_VARIABLE=2,label_exp=!master #356197
2. AXIS_VARIABLE=3,label_exp=!master #356197
  1. LocalFile.ContentPagesWithFragmentConfiguration#AddTextConfigurationFragmentToContentPage - Poshi Report - Poshi Summary - Console Output
  2. LocalFile.ContentPagesWithSearch#SearchStaticText - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/77
Job Results:
2 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #359663
  Build was aborted
2. AXIS_VARIABLE=1,label_exp=!master #359663
...

brianchandotcom · 2020-02-26T03:47:07Z

Merged. Thank you.
View total diff: c8ed1d4...c190d83

achaparro and others added 23 commits February 25, 2020 10:34

LPS-107396 If we don't add null or not null we don't have to include …

d50c100

…it in the query

LPS-107396 Add nullable clause in those databases which allow it

7de22dc

LPS-107396 Add it in two commands for Postgres

f64d257

LPS-107396 Implementation for DB2. DB2 does not allow to execute two …

8b197d4

…statements in the same line

LPS-107396 Postgres does not allow to change the type and the nullabl…

372806c

…e condition in the same statement

LPS-107396 Oracle throws an error if we try to change the nullable co…

d54452f

…ndition when the column already has that condition

LPS-107396 SQLServer returns NVARCHAR for Varchar, string o text types

750d7f5

LPS-107396 I think we do not need this anymore

7ac5a2e

LPS-107396 Take into account the case when nullable is blank

9c09da7

LPS-107396 New integration tests

770990d

LPS-107396 Null is always the last word when we have 5 words. In this…

7f897f3

… way we accept templates with semicolon

LPS-107396 Now we need to validate if the nullable condition has been…

de60548

… added for Hypersonic

LPS-107396 New unit tests for reword with every database and DBInspector

d036ad9

LPS-107396 Use another column instead of name since alter table colum…

98615dd

…n name is confusing

LPS-107396 Use CharPool

66eba13

LPS-107396 Less String chopping

5822a7a

LPS-107396 Fix test class name

0a30ddb

LPS-107396 Implement a more generic logic for DB2

c18eee5

LPS-107396 Throw SQLException where buildSQL is used

2533612

LPS-107396 SQLException is allowed now

b182892

LPS-107396 Proper assert

7a77119

LPS-107396 Make it test friendly

4180b47

LPS-107396 Avoid powermock

eabdcfd

shuyangzhou mentioned this pull request Feb 26, 2020

Lps 107396 #85277

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Feb 26, 2020

liferay-continuous-integration added the ci:test:relevant - pending label Feb 26, 2020

liferay-continuous-integration added ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 26, 2020

brianchandotcom closed this Feb 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lps 107396 #85284

Lps 107396 #85284

shuyangzhou commented Feb 26, 2020

liferay-continuous-integration commented Feb 26, 2020

liferay-continuous-integration commented Feb 26, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 26, 2020

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

8 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/35

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/64

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/76

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/77

Job Results:

brianchandotcom commented Feb 26, 2020

Lps 107396 #85284

Lps 107396 #85284

Conversation

shuyangzhou commented Feb 26, 2020

liferay-continuous-integration commented Feb 26, 2020

liferay-continuous-integration commented Feb 26, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 21 seconds 259 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 26, 2020

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 117 out of 125 jobs passed in 3 hours 14 minutes 57 seconds 927 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

8 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/35

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/55

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/64

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/76

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/77

Job Results:

brianchandotcom commented Feb 26, 2020