LPS-112018 Remove <clay:button> and use hardcoded markup #87685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Hi @brianchandotcom,, This fixes a performance regression. We need to keep dd25b89 to avoid unnecessary calculations. Thanks! |
|
@4lejandrito slack me how bad the perf is? Thx. |
|
Merged. Thx. |
liferay-continuous-integration
deleted the
ci-forward-pr-459-pr-460-sender-4lejandrito-ts-1587047559311
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: 4lejandrito#460
@4lejandrito
Original pull request comment:
@ambrinchaudhary, @boton, @dantewang, @GinsonRen
✔️ ci:test:stable - 17 out of 17 jobs passed
✔️ ci:test:relevant - 29 out of 29 jobs passed in 3 hours 23 seconds 115 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: e145c48e9115bd2ede749d802e49483b5341bf78
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: dedb2cf07c7105cbb78b2a4f981022f7a7a84946
ci:test:stable - 17 out of 17 jobs PASSED
17 Successful Jobs:
ci:test:relevant - 29 out of 29 jobs PASSED
29 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 45 seconds 390 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: e145c48e9115bd2ede749d802e49483b5341bf78
Sender Branch:
Branch Name: pr-459
1 out of 1jobs PASSEDBranch GIT ID: bb9f21267fe40d5ad2d0834cd554d6cdeec174b9
1 Successful Jobs:
For more details click here.