LPS-101626 Deprecate Liferay.Util.isFunction #87839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2020 14:02
Here are the reasons why we are removing this method: - It's basic JavaScript - We already have `isFunction` provided by AUI (see `Lang.isFunction`), metal.js, as well as other inline definitions.
Updated `@deprecated` comment based on [brianchandotcom/liferay-portal@dea258f](brianchandotcom@dea258f)
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-101626-pr-209-sender-julien-ts-1587541386230
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: https://github.com/wincent/liferay-portal/pull/209
@julien
@wincent
Original pull request comment:
Here are the reasons why we are removing this method:
It's basic JavaScript
We already have
isFunctionprovided by AUI (seeLang.isFunction), metal.js, as well as other inline definitions.Previously reviewed at: https://github.com/wincent/liferay-portal/pull/207
✔️ ci:test:stable - 18 out of 18 jobs passed
✔️ ci:test:relevant - 35 out of 35 jobs passed in 1 hour 53 minutes 26 seconds 9 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 16ee1f13eb07dae3c7c937c83c8684b89cff1d28
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: b4536024712dac54820c4c13f7cf737b2b7a945b
ci:test:stable - 18 out of 18 jobs PASSED
18 Successful Jobs:
ci:test:relevant - 35 out of 35 jobs PASSED
35 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 28 seconds 694 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 296ff93c5fcb45f4659fa3049cc3c74d7dcb6414
Sender Branch:
Branch Name: LPS-101626
1 out of 1jobs PASSEDBranch GIT ID: 445bf6868c330b72c43761f97fd7f7ace067863f
1 Successful Jobs:
For more details click here.