Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-118295 Improve Classic TokenDefinition labels #92144

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-frontend#195 (Took 1 ci:forward attempt in 4 minutes)

@jbalsas
@liferay-frontend

Original pull request comment:
Small followup on our Classic Theme Token Definition that:

  • Replaces (sm), (md) and (lg) abbreviations from labels in favour of the full words
  • Sorts tokens so they always follow: Base - Small - Large ... ordering
  • Uses labels in token set collapsibles

Screen Shot 2020-07-31 at 13 57 39

Screen Shot 2020-07-31 at 13 57 47

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a20c7ad437fccefb74adcfddf2d750d339b555c2

Sender Branch:

Branch Name: LPS-118295
Branch GIT ID: a76e6bce27740ee7dbabf8b167966b1ae383d16e

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 56 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a20c7ad437fccefb74adcfddf2d750d339b555c2

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a2989be147835c295b16fd5637140c9d4cd9de61

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 46 out of 46 jobs PASSED
46 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@jbalsas
Copy link

jbalsas commented Aug 3, 2020

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 5e50875...607684b

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-118295-pr-195-sender-jbalsas-ts-1596446658420 branch August 10, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants