LPS-118295 Improve Classic TokenDefinition labels #195

jbalsas · 2020-07-31T13:01:40Z

Small followup on our Classic Theme Token Definition that:

Replaces (sm), (md) and (lg) abbreviations from labels in favour of the full words
Sorts tokens so they always follow: Base - Small - Large ... ordering
Uses labels in token set collapsibles

liferay-continuous-integration · 2020-07-31T13:01:49Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

wincent · 2020-07-31T14:56:59Z

ci:test:sf

wincent · 2020-07-31T14:57:07Z

ci:test:relevant

wincent

I know you didn't ask for my review, but...

liferay-continuous-integration · 2020-07-31T15:03:08Z

❌ ci:test:sf - 0 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1c223735e06ef26022ce7788d13a4edab3e1b98e

Sender Branch:

Branch Name: LPS-118295
Branch GIT ID: d4e49c2e4b3f4289e10ab3e5374609336f6c2471

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

 [sync-dir] 0 files synchronized in 521ms
     [echo] Executing Gradle task: :portalYarnCheckFormat
     [exec] Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
     [exec] Configuration on demand is an incubating feature.
     [exec] > Task :downloadNode SKIPPED
     [exec] > Task :npmInstall SKIPPED
     [exec] 
     [exec] > Task :yarnInstall
     [exec] yarn install v1.13.0
     [exec] [1/4] Resolving packages...
     [exec] success Already up-to-date.
     [exec] Done in 1.45s.
     [exec] 
     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ liferay-npm-scripts check
     [exec] Prettier checked 2 files
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/style-book/style-book-web/src/main/resources/META-INF/resources/js/style-book-editor/FrontendTokenSet.js
     [exec]   26:66  error  'name' is defined but never used. Allowed unused args must match /^_/u.  no-unused-vars
     [exec] 
     [exec] ??? 1 problem (1 error, 0 warnings)
     [exec] 
     [exec] 1 of 3 jobs failed
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] Gradle build finished at 2020-07-31 15:02:54.855.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:166)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:163)
     [exec] 	at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:191)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)

wincent · 2020-07-31T15:23:36Z

   26:66  error  'name' is defined but never used. Allowed unused args must match /^_/u.  no-unused-vars

liferay-continuous-integration · 2020-07-31T16:39:16Z

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 41 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1c223735e06ef26022ce7788d13a4edab3e1b98e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2aa558d7587a046d654b60e91d9b21cb5e106df3

ci:test:stable - 21 out of 21 jobs PASSED

21 Successful Jobs:

ci:test:relevant - 46 out of 46 jobs PASSED

46 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2020-07-31T17:12:11Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6874
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#195
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#195 - 2020-07-31[07:57:47]
Spira Jenkins Build:publish-spira-report#1939

liferay-continuous-integration · 2020-07-31T17:28:52Z

Jenkins Build:test-portal-source-format#3531
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#195
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#195 - 2020-07-31[07:57:29]
Spira Jenkins Build:publish-spira-report#1939

…text qualifiers

jbalsas · 2020-08-03T07:08:46Z

Well, we all know the drill... rebased, removed unnecessary name variable and force-pushed 🙈

jbalsas · 2020-08-03T07:13:06Z

ci:test:sf

liferay-continuous-integration · 2020-08-03T07:16:56Z

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a20c7ad437fccefb74adcfddf2d750d339b555c2

Sender Branch:

Branch Name: LPS-118295
Branch GIT ID: a76e6bce27740ee7dbabf8b167966b1ae383d16e

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./build.properties expected:<...\
     [java]     #    dxp/apps/[]multi-factor-authent...> but was:<...\
     [java]     #    dxp/apps/[lcs,\
     [java]     #    dxp/apps/]multi-factor-authent...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:448)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:269)
[stopwatch] [run.batch.test.action: 1:40.524 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:573: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:707: Java returned: 1
      [get] Getting: http://test-1-11/job/test-portal-source-format/4358//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20200803241642807.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20200803241642807.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null956865276.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null52341039

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 216ms

[junitreport] Deleting: /tmp/null52341039

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 08-03-2020 00:16:48:084 PDT

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[echo]

[echo] Ant GC log:

[echo]

[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)

jbalsas · 2020-08-03T07:17:33Z

ci:test:relevant

liferay-continuous-integration · 2020-08-03T07:19:05Z

Jenkins Build:test-portal-source-format#4358
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#195
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#195 - 2020-08-03[00:13:37]
Spira Jenkins Build:publish-spira-report#1826

liferay-continuous-integration · 2020-08-03T09:14:35Z

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 56 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a20c7ad437fccefb74adcfddf2d750d339b555c2

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a2989be147835c295b16fd5637140c9d4cd9de61

ci:test:stable - 21 out of 21 jobs PASSED

21 Successful Jobs:

ci:test:relevant - 46 out of 46 jobs PASSED

46 Successful Jobs:

For more details click here.

jbalsas · 2020-08-03T09:16:10Z

ci:test:sf

liferay-continuous-integration · 2020-08-03T09:19:29Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a20c7ad437fccefb74adcfddf2d750d339b555c2

Sender Branch:

Branch Name: LPS-118295
Branch GIT ID: a76e6bce27740ee7dbabf8b167966b1ae383d16e

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

jbalsas · 2020-08-03T09:20:49Z

I know you didn't ask for my review, but...

I'll take that as approval to forward this 😂

jbalsas · 2020-08-03T09:20:57Z

ci:forward

liferay-continuous-integration · 2020-08-03T09:21:05Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-08-03T09:21:06Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2020-08-03T09:21:28Z

Jenkins Build:test-portal-source-format#2941
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#195
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#195 - 2020-08-03[02:16:34]
Spira Jenkins Build:publish-spira-report#4977

liferay-continuous-integration · 2020-08-03T09:24:17Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-08-03T09:24:51Z

Pull request has been successfully forwarded to brianchandotcom#92144

liferay-continuous-integration · 2020-08-03T19:18:49Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6321
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#195
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#195 - 2020-08-03[00:18:05]
Spira Jenkins Build:publish-spira-report#2080

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending labels Jul 31, 2020

wincent approved these changes Jul 31, 2020

View reviewed changes

liferay-continuous-integration added ci:test:sf - failure and removed ci:test:sf - pending labels Jul 31, 2020

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jul 31, 2020

jbalsas added 2 commits August 3, 2020 08:52

LPS-118295 Uses label instead of name to show localized dropdown titles

18b810e

LPS-118295 Removes size abbreviations in favour of whole words or con…

a76e6bc

…text qualifiers

jbalsas force-pushed the LPS-118295 branch from d4e49c2 to a76e6bc Compare August 3, 2020 06:58

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - failure ci:test:sf - pending labels Aug 3, 2020

liferay-continuous-integration removed the ci:test:relevant - success label Aug 3, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:stable - success labels Aug 3, 2020

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Aug 3, 2020

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Aug 3, 2020

liferay-continuous-integration mentioned this pull request Aug 3, 2020

LPS-118295 Improve Classic TokenDefinition labels brianchandotcom/liferay-portal#92144

Closed

liferay-continuous-integration closed this Aug 3, 2020

jbalsas deleted the LPS-118295 branch October 30, 2020 17:29

LPS-118295 Improve Classic TokenDefinition labels #195

LPS-118295 Improve Classic TokenDefinition labels #195

Conversation

jbalsas commented Jul 31, 2020

liferay-continuous-integration commented Jul 31, 2020

wincent commented Jul 31, 2020

wincent commented Jul 31, 2020

wincent left a comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Jul 31, 2020

❌ ci:test:sf - 0 out of 1 jobs passed in 6 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

wincent commented Jul 31, 2020

liferay-continuous-integration commented Jul 31, 2020

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 41 minutes

Base Branch:

Copied in Private Modules Branch:

For more details click here.

liferay-continuous-integration commented Jul 31, 2020

liferay-continuous-integration commented Jul 31, 2020

jbalsas commented Aug 3, 2020

jbalsas commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

jbalsas commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 56 minutes

Base Branch:

Copied in Private Modules Branch:

For more details click here.

jbalsas commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

jbalsas commented Aug 3, 2020

jbalsas commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020

liferay-continuous-integration commented Aug 3, 2020