Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-125847 - Provide button to Duplicate experiences #97917

Closed
wants to merge 12 commits into from
Closed

LPS-125847 - Provide button to Duplicate experiences #97917

wants to merge 12 commits into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-tango#769 (Took 3 ci:forward attempts in 2 hours 43 minutes)

@darquesdev
@liferay-tango

Original pull request comment:
Motivation
As part of As a marketer, I want to duplicate experiences it is necessary to provide a button to duplicate experiences in the ExperienceSelector in a way that:

  • The tooltip shows: Duplicate Experience
  • A new experience with [the same name] + Copy and the same audience (Segment) appears in the last position of the list, and a success message appears: Experience successfully duplicated
  • The new experience is selected in the dropdown and the user is led to the new one in editing mode
LPS-125847.mov

Solution
A new ClayButtonWithIcon has been added to ExperienceActions in ExperienceItem. And similar required logic has been added as the rest of actions:

  1. Add duplicateExperience method to ExperienceService
  2. Add reducer
  3. Add new action type and thunk function
  4. Logic to handle segments duplication and use it properly

How to test it:
Manually:

  1. Create Segment S1 (nevertheless the criteria)
  2. Create a Page
  3. Create experience E1 and add some content
  4. Duplicate experience E1

Automatically:
Unit tests will be added in a separate PR

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 24 out of 25 jobs passed in 2 hours 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d907a659b8b947d415dd4439c9129caa6ba7150a

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2b89e6be0ae0f6e12dec390930d3e9525006e687

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 25 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at b30d0d3:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1163 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=4,label_exp=!master #462044
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7d640f4b27841520daf470b08dbe8683c2f2e033

Sender Branch:

Branch Name: LPS-125847.3
Branch GIT ID: 52654d702847f0a68a6956f9e99c11052732bd94

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

Closed
@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 34f1383...2c156e3

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-125847.3-pr-769-sender-darquesdev-ts-1611167004584 branch January 28, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liferay-continuous-integration @brianchandotcom