Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code is matching on partial variable names #147

Open
briandk opened this issue Feb 24, 2012 · 3 comments
Open

Some code is matching on partial variable names #147

briandk opened this issue Feb 24, 2012 · 3 comments

Comments

@briandk
Copy link
Owner

briandk commented Feb 24, 2012

For example:

stats.vcj<-jitter(stats.vc, am = ammt)

source: https://github.com/briandk/granovaGG/blob/dev/R/granovagg.1w.R#L244

@WilDoane
Copy link
Collaborator

Since "am" is the actual parameter being passed into jitter, an R {base} function, which is being partially matched on the formal parameter "amount", can't we simply change

stats.vcj<-jitter(stats.vc, am = ammt)

to

stats.vcj<-jitter(stats.vc, ammount = ammt)

with zero impact on other code and the public interface?

@briandk
Copy link
Owner Author

briandk commented Feb 24, 2012

In short, yes.

Part of what's frustrating is that that particular statement doesn't get used by any of our function's computations. It's now inconsequential legacy code that I've been too timid to take out.

@briandk
Copy link
Owner Author

briandk commented Aug 31, 2012

I think I'm going to address this issue in our next major release (1.3, presumably), and keep a pretty conservative list of changes for the 1.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants