Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignite] Add Apache Ignite clients 'ignite' and 'ignite-sql' #1118

Closed
wants to merge 105 commits into from
Closed

[ignite] Add Apache Ignite clients 'ignite' and 'ignite-sql' #1118

wants to merge 105 commits into from

Conversation

isuntsov-gridgain
Copy link
Contributor

Hi,
Could you please add AI clients (https://ignite.apache.org) from my PR to your repository?
We've added:

  • ignite directory that contains clients, tests, and config
  • ignite section in pom.xml

Also Apache Ignite clients was added to the DATABASES list (ycsb script).

Thanks!

Put, Update, Delete is ready
Get almost
pom version   minor code style
dependency fix
check style and dependency fixes
enable verbose mode by default
Use cache settings from cluster
Add debug information for "read" method
Fix "read" method to read all fields
Fix "read" method to read all fields
Check fields for null and empty
fix missing return statement
@isuntsov-gridgain
Copy link
Contributor Author

@busbey please take a look at my PR. I've finished work with requested changes.

@busbey
Copy link
Collaborator

busbey commented Jul 6, 2018

Note to self when we squash this for merge:

@author Sergey Puchnin
@author Taras Ledkov
@author Oleg Ostanin

@busbey
Copy link
Collaborator

busbey commented Jul 6, 2018

I think those author names have to include email addresses if we want github to attribute things properly. I can probably get them from the current commit history.

@busbey
Copy link
Collaborator

busbey commented Jul 6, 2018

I presume some of these changes are due to how github is handling diffing a merge. let me see if I can do this faster with a local checkout.

@busbey
Copy link
Collaborator

busbey commented Jul 6, 2018

@isuntsov-gridgain would you prefer the author tag be for the gmail address that shows up in the current list of commits or the gridgain email address that shows up?

@busbey
Copy link
Collaborator

busbey commented Jul 6, 2018

@isuntsov-gridgain I have a few changes I'd like, but they're all small things. I've got this PR ready to merge as a squashed-and-rebase, so I'd like to proceed and then file a follow-on issue with the stuff that should get changed. would that be okay with you?

@isuntsov-gridgain
Copy link
Contributor Author

isuntsov-gridgain commented Jul 9, 2018 via email

@isuntsov-gridgain
Copy link
Contributor Author

@busbey I guess it should be emails from the commit list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants