-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ignite] Add Apache Ignite clients 'ignite' and 'ignite-sql' #1118
[ignite] Add Apache Ignite clients 'ignite' and 'ignite-sql' #1118
Conversation
Put, Update, Delete is ready Get almost
Initial commit
Get is ready
pom version minor code style
add ignite as a database
dependency fix
check style and dependency fixes
fix setHostIP
fix for lab
enable verbose mode by default
Use cache settings from cluster Add debug information for "read" method
Use Last Ignite version
Fix "read" method to read all fields
Fix "read" method to read all fields
Added test for all fields
Check fields for null and empty
Added test for not_found
another NPE check
fix missing return statement
@busbey please take a look at my PR. I've finished work with requested changes. |
I think those author names have to include email addresses if we want github to attribute things properly. I can probably get them from the current commit history. |
I presume some of these changes are due to how github is handling diffing a merge. let me see if I can do this faster with a local checkout. |
@isuntsov-gridgain would you prefer the author tag be for the gmail address that shows up in the current list of commits or the gridgain email address that shows up? |
@isuntsov-gridgain I have a few changes I'd like, but they're all small things. I've got this PR ready to merge as a squashed-and-rebase, so I'd like to proceed and then file a follow-on issue with the stuff that should get changed. would that be okay with you? |
Great! I don't mind.
пт, 6 июл. 2018 г., 23:12 Sean Busbey <notifications@github.com>:
… @isuntsov-gridgain <https://github.com/isuntsov-gridgain> I have a few
changes I'd like, but they're all small things. I've got this PR ready to
merge as a squashed-and-rebase, so I'd like to proceed and then file a
follow-on issue with the stuff that should get changed. would that be okay
with you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIdh7wc6QAxGfSWukvleCcnj5_XZ9hXZks5uD8SpgaJpZM4S_7i3>
.
|
@busbey I guess it should be emails from the commit list. |
Hi,
Could you please add AI clients (https://ignite.apache.org) from my PR to your repository?
We've added:
Also Apache Ignite clients was added to the DATABASES list (ycsb script).
Thanks!