Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some calendar date events are failing with server error #6

Closed
denshu-arte opened this issue Mar 13, 2023 · 3 comments
Closed

Some calendar date events are failing with server error #6

denshu-arte opened this issue Mar 13, 2023 · 3 comments

Comments

@denshu-arte
Copy link

Hello, there. Found a set of events where the Orthocal API doesn't work (returns server error).

List of API calls that don't work (there might probably be more):

Some notes (added it in case it's helpful with finding the reason for the bug):

  • Though julian/2025/4/8/ fails, gregorian/2025/3/26/ works fine.
  • Also julian/2024/4/ seems to have failed because there's an error in calculation of julian/2024/4/8/ i.e. month calculation seems to fail because one day of the sequence cannot be calculated.

Hope the issue can be resolved soon!

Also, could you please give me some information on when you are planning to look into this issue? I'm working on a personal project using this API and would like to know if I could continue soon or should postpone it for a bit.

@denshu-arte
Copy link
Author

Hey @brianglass
Any thoughts/updates on this?

@brianglass
Copy link
Owner

@denshu-arte, thank you for the bug report. I just deployed a fix for these this afternoon. Please try again and let me know if it is resolved. The error occurs if there is a Leave-taking of Annunciation that occurs on a non-liturgy day. You can review the commit here: abedc58

@denshu-arte
Copy link
Author

@brianglass yes, it works now. Thank you for the fix. I'll be closing the issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants