Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where jyutping is empty? #5

Open
briankung opened this issue Dec 8, 2021 · 0 comments
Open

Handle cases where jyutping is empty? #5

briankung opened this issue Dec 8, 2021 · 0 comments

Comments

@briankung
Copy link
Owner

Currently pinyin is handled with a combinator::opt for cases when pinyin is missing. I believe this is a pathological case from the CC-CEDICT files I've downloaded, but I could be wrong. Either way, consider either treating pinyin as mandatory or jyutping as optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant