Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancement: Add RBAC for admin interfaces #19

Closed
brianmiller opened this issue Dec 14, 2022 · 1 comment
Closed

Feature Enhancement: Add RBAC for admin interfaces #19

brianmiller opened this issue Dec 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@brianmiller
Copy link
Owner

We currently depend on a reverse proxy to control access to the admin interfaces. We're removing the need for a reverse proxy to reduce as much complexity as possible. While a reverse proxy will still be optional, it will no longer be required. Therefore, we need to implement an RBAC system.

We will store admin SteamIDs in the PhValheim MariaDB and only render admin interfaces if a match is detected.

@brianmiller brianmiller added the enhancement New feature or request label Dec 14, 2022
@brianmiller
Copy link
Owner Author

brianmiller commented Dec 21, 2022

We're punting on RBAC. I don't have time to build something too elaborate.

Commit 47b5594 isolates the /admin/ pages to a dedicated port.

You can review the README changes here:
https://github.com/brianmiller/phvalheim-server#container-ports
https://github.com/brianmiller/phvalheim-server#docker-command-line

A note regarding Unraid:
The Unraid docker template for phvalheim-server has been updated to include an additional variable:
image

Oddly, Unraid doesn't update the container edit screen if the docker template has been updated. The only way I can see to get Unraid to render the new template is to:

  • Stop the container
  • Delete the container (do not delete your stateful directory)
  • Deploy a new container, targeting the same stateful directory destination

image

Note: This release also includes preparatory database update logic for future schema changes. You may see "Upgrading schema to version xyz..." in the engine logs. These database changes are not being used yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant