Backport nightly fixes to V0.11 #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made against the master branch because no v0.11 branch exists. I've locally created a branch off of the
0.11.0tag which these commits should be applied to.This backports the nightly fix changes made to master and released in
0.13.0-alphato0.11.0. The crate version is updated to0.11.1for easy releasing.I want to keep the argument short: Rocket v0.3 uses ring 0.11 and is thus currently broken on the latest nightlies as a result (rwf2/Rocket#513). Because of #575, we cannot update
ringto0.13.0-alphawithout a breaking release, which Rocket is not ready for. Even then, none of Rocket'sringdependents have upgraded toring 0.13.0-alpha(cookie,rustls,hyper-sync-rustls), so this wouldn't be technically feasible either. This PR is the only way to get Rocket working on nightly.I understand that you only want to support the latest version of ring. Were it not for #575, while still unfavorable to the community, it would be a tenable position; many crates could simply upgrade to the latest version risk-free. But coupling #575 with your present stance creates a truly difficult scenario for crates depending on
ring. At present time, there are 69 crates depending onring, none of which are on0.13.0-alpha, and thus the majority broken on nightly. Your position makesringdifficult to use, inverts control over release schedules, and is currently breaking other projects. If you don't want to support older versions ofring, at least accept PRs when the community wants to support them for you. Please don't simply silence opinions by locking issues and PRs such as #599, #598, and #575.Please accept this PR and release
0.11.1. I'll submit a PR for0.12.2as well.