Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to Artifactory calls #7

Closed
briantist opened this issue Aug 8, 2022 · 0 comments · Fixed by #9
Closed

Add retries to Artifactory calls #7

briantist opened this issue Aug 8, 2022 · 0 comments · Fixed by #9
Assignees

Comments

@briantist
Copy link
Owner

Have been starting to see cases where a sudden flood of connections (like in a CI with a big parallel matrix) causes calls to artifactory to fail, ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')).

One way we could do this is with urllib3's Retry class, by ensuring we create a Session ourselves and passing it to ArtifactoryPath: https://github.com/devopshq/artifactory#session

We might need to be careful with this to ensure that everywhere we instantiate such an object we also use a proper session.

To that end, we could maybe subclass ArtifactoryPath with like GalactoryPath or whatever, that handles retryability.


Another option is to use a library like backoff to wrap calls we make. But I think that might not be the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant