Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Future Date #245

Closed
hound672 opened this issue Jul 3, 2023 · 3 comments · Fixed by #246
Closed

Add Future Date #245

hound672 opened this issue Jul 3, 2023 · 3 comments · Fixed by #246
Assignees

Comments

@hound672
Copy link
Contributor

hound672 commented Jul 3, 2023

Hi.
Python's faker lib has future_date

It's just shortcat for getting future time, instead of doing smth like:

time.Now().Add(time.hour * rand())

Don't you mind if I'll make PR?

@brianvoe
Copy link
Owner

brianvoe commented Jul 3, 2023

If you want to add a pr I would be more than happy to add it. Just make sure it has the examples and benchmarks, lookup and readme.

@brianvoe brianvoe changed the title Future date Add Future Date Jul 3, 2023
@hound672
Copy link
Contributor Author

hound672 commented Jul 4, 2023

examples

I think it'd not to so easy, since result of FutureDate depends on current time.

@brianvoe
Copy link
Owner

brianvoe commented Jul 6, 2023

v6.23.0

@brianvoe brianvoe closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants