Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions don't support quoted strings #20

Closed
Brickster opened this issue Aug 17, 2015 · 0 comments
Closed

Extensions don't support quoted strings #20

Brickster opened this issue Aug 17, 2015 · 0 comments
Labels

Comments

@Brickster
Copy link
Owner

If an extension contains a quoted string, the underlying command isn't executed correctly.

$ git config git-state.extensions.print-message "printmessage \"this is the message\""
$ git state -STBLR
# print-message

    message: this
$

Use shlex so that quotes strings are maintained:

import shlex
command = shlex.split('printmessage "this is the message"')
@Brickster Brickster added the bug label Aug 17, 2015
Brickster pushed a commit that referenced this issue Aug 18, 2015
Fixes issues with the new extension feature:

- Extensions don't support quoted strings #20
- Empty extensions don't respect --show-empty #21
Brickster added a commit that referenced this issue Jan 8, 2018
Previously, extensions with quoted string wouldn't work properly since
the quotes weren't respected.

Fixes #20
Brickster added a commit that referenced this issue Jan 8, 2018
Fixes issues with the new extension feature:

- Extensions don't support quoted strings #20
- Empty extensions don't respect --show-empty #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant