Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function schema: Support both "values" and "schemaReference" in single argument #606

Open
Joelant05 opened this issue Sep 10, 2022 · 2 comments · May be fixed by #649
Open

Function schema: Support both "values" and "schemaReference" in single argument #606

Joelant05 opened this issue Sep 10, 2022 · 2 comments · May be fixed by #649
Assignees
Labels
data Something that requires work inside of the editor-packages repo
Milestone

Comments

@Joelant05
Copy link
Member

This would help condense the function schema significantly, since commands like /loot would have half as many definitions in the schema

@Joelant05 Joelant05 added the data Something that requires work inside of the editor-packages repo label Sep 10, 2022
@Joelant05 Joelant05 added this to the v2.3.X milestone Sep 10, 2022
@Joelant05 Joelant05 self-assigned this Sep 11, 2022
@solvedDev
Copy link
Member

Can you share a code example of the syntax you'd like us to support, @Joelant05?

@Joelant05
Copy link
Member Author

Basically I just want to be able to use schemaReference and values in the same command argument, e.g.

{
	"additionalData": {
		"schemaReference": "/data/packages/minecraftBedrock/schema/general/reference/identifiers.json#/definitions/item_identifiers",
		"values": ["mainhand", "offhand"]
	},
}

I've actually already implemented this locally, but haven't pushed it yet since I couldn't figure out a good way for the validator to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Something that requires work inside of the editor-packages repo
Projects
Status: 📚 Backlog
3 participants