Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfiles: cache go mods in their own layer #104

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Dockerfiles: cache go mods in their own layer #104

merged 2 commits into from
Apr 8, 2022

Conversation

krancour
Copy link
Contributor

@krancour krancour commented Apr 7, 2022

This PR caches resolved dependencies in their own layer to improve build time when built repeatedly -- i.e. during dev.

Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
@krancour krancour added the chore A small task reviewable by non-maintainers label Apr 7, 2022
@krancour krancour added this to the v1.2.0 milestone Apr 7, 2022
@krancour krancour requested a review from vdice April 7, 2022 22:58
@krancour krancour self-assigned this Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #104 (c7fda97) into main (8bf7d94) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files          12       12           
  Lines        1238     1238           
=======================================
  Hits          911      911           
  Misses        307      307           
  Partials       20       20           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@krancour krancour merged commit 0c3683f into brigadecore:main Apr 8, 2022
@krancour krancour deleted the faster-image-builds branch April 8, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A small task reviewable by non-maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants