Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix on chart link #733

Merged
merged 1 commit into from
Dec 28, 2018
Merged

minor fix on chart link #733

merged 1 commit into from
Dec 28, 2018

Conversation

dgkanatsios
Copy link
Contributor

No description provided.

@dgkanatsios dgkanatsios self-assigned this Dec 28, 2018
@dgkanatsios
Copy link
Contributor Author

as already discussed, linter fail will be fixed when this commit is merged

vdice
vdice approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch; thanks!

@dgkanatsios
Copy link
Contributor Author

#737 was introduced to fix linter failures

@dgkanatsios dgkanatsios merged commit 491d033 into brigadecore:master Dec 28, 2018
@dgkanatsios dgkanatsios deleted the fix-chart-link branch December 28, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

Assignees

@dgkanatsios dgkanatsios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgkanatsios @vdice