This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Should use a secret for sensitive brigade-github-app configuration #48
Labels
bug
Something isn't working
Currently, the
brigade-github-app
chart creates a config map that includes a sensitivekey.pem
field. The deployment mounts this config map to/etc/brigade-github-app
and, in turn, the containerized brigade-github-app process in each pod consumes/etc/brigade-github-app/key.pem
.Since the contents of
key.pem
are sensitive, it would be more proper and more safe to store this in a secret.This can be accomplished pretty easily with changes to the chart and no changes to the brigade-github-app software itself.
This is not a breaking change:
Eliminate the
brigade-github-app
config map (sincekey.pem
) is its only field anyway.Add
key.pem
field to the existingbrigade-github-app
secret.In the deployment, mount the
brigade-github-app
secret to/etc/brigade-github-app
in place of thebrigade-github-app
config map.The text was updated successfully, but these errors were encountered: