-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert most tests in tests/ to YAML ztests #342
Conversation
* Add package ztest to run formulaic tests defined in YAML files that look like this: zql: count() input: | #0:record[i:int64] 0:[1;] 0:[2;] output: | #0:record[count:uint64] 0:[2;] * Convert tests in tests/formats and most of those in tests/suite to YAML. As a side effect, both "make test-unit" and "make test-system" now run all of the converted tests. (test-unit uses driver.(*Driver).Run, while test-system uses the dist/zq executable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
I'm not very familiar with yaml, is |
@aswan: We could always define our own binary encoding above YAML. Do you think that's worth doing? |
Maybe? That could happen in a later follow-up for sure if it seems like it would be worthwhile. |
look like this:
YAML. As a side effect, both "make test-unit" and "make test-system"
now run all of the converted tests. (test-unit uses
driver.(*Driver).Run, while test-system uses the dist/zq executable).
Future Work