Rework errors in compiler/parser #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ErrorList, a list of Errors, and SourceSet, a struct containing
Zed program text and source file offsets. In the future,
compiler/semantic will use these types to return multiple errors that
point into the program.
* Remove ImproveError and NewError.
* Change ParseZed to return an ErrorList when Parse fails.
* Change ParseZed and ConcatSource to return a SourceSet.
* In api.Error, replace the `Info interface{}` field with
`ComplationErrors parser.ErrorList`.
Co-authored-by: Matthew Nibecker <hello@mattnibecker.com>
mattnibs
approved these changes
May 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #5122, from which compiler/parser/source.go and the
parser.Error.Errorimplementation are copied.Add ErrorList, a list of Errors, and SourceSet, a struct containing Zed program text and source file offsets. In the future, compiler/semantic will use these types to return multiple errors that point into the program.
Remove ImproveError and NewError.
Change ParseZed to return an ErrorList when Parse fails.
Change ParseZed and ConcatSource to return a SourceSet.
In api.Error, replace the
Info interface{}field withComplationErrors parser.ErrorList.