-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lift optimization for dag.Fork #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this closes #4559, then shouldn't it lift Never mind me. It does lift a
into the fork
here?a
into the fork
.
$ zc -C -O 'fork ( => pass => pass ) | where a'
reader
| fork (
=>
pass
=>
pass
)
| where a
Aww yeah! I saw the #5070 reference so I ran its repro steps on the branch to see it's really true. 11+ minutes down to <18 seconds. Nice work @mattnibs!
|
nwt
approved these changes
Jul 11, 2024
nwt
added a commit
that referenced
this pull request
Aug 2, 2024
This test went flaky with #5174 because the optimizer began lifting the head operator into the legs of the fork operator, causing the pass leg to stop pulling until EOS.
nwt
added a commit
that referenced
this pull request
Aug 2, 2024
This test went flaky with #5174 because the optimizer began lifting the head operator into the legs of the fork operator, causing the pass leg to stop pulling until EOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes bug where the lift optimization would not get applied on eligible sequences with a length of 2.
Closes #4559, closes #4503, closes #5070