-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Zui Data Migration Script #2409
Comments
I'm verifiying this using GA Brim v0.31.0 and the Zui test artifacts linked from https://github.com/brimdata/brim/actions/runs/2827034553. Steps for testing migration
Steps for testing that migration only runs once
Steps for testing that Zui works fine if there never was any legacy Brim present
|
On macOS, testing migration showed the following in the Zui log:
When testing that migration only ran once, upon relaunching Zui, only the following lines were added to the log:
...and none of the additional data we'd added in Brim was visible in the app. For testing without legacy Brim present, the Zui log on first launch looked like:
...and test lakes and saved queries worked as expected. |
On Windows, testing migration showed the following in the Zui log:
While the tests with the migrated lakes and saved query all worked fine, I noticed that when I installed Zui, my Brim was immediately uninstalled, which is the same symptom we saw with Zui Insider tracked in #2459. As a result, I wasn't able to do the tests that migration would run only once. For testing without legacy Brim present, the Zui log on first launch looked like:
...and test lakes and saved queries worked as expected. |
On Ubuntu Linux 21.10, testing migration showed the following in the Zui log:
When testing that migration only ran once, upon relaunching Zui, only the following lines were added to the log:
...and none of the additional data we'd added in Brim was visible in the app. For testing without legacy Brim present, the Zui log on first launch looked like:
...and test lakes and saved queries worked as expected. |
On CentOS 8, testing migration showed the following in the Zui log:
When trying to test that migration only ran once, I was reminded (as documented here) that with the RPM installer in particular, there's conflicts that have always required uninstalling an older version of Brim before installing a newer one, and the same turns out to be true when installing Zui while Brim is still installed. Therefore the test of bouncing back to Brim and adding data doesn't really apply here, though FWIW it worked ok on Ubuntu Linux as shown above. For testing without legacy Brim present, the Zui log on first launch looked like:
...and test lakes and saved queries worked as expected. |
That covers verification of all the platform permutations, and I think we're in good shape here. Thanks @mason-fish! |
When Zui launches for the first time ever, write a script to go get the app state and the lake from the Brim directory.
Copy it into the Zui directory, then restart the app.
Test that permissions work.
The text was updated successfully, but these errors were encountered: