Simplify rewrite usage

bripkens · Apr 11, 2015 · 5631650 · 5631650
1 parent fbab7ea
commit 5631650
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -81,8 +81,9 @@ Override the index when the request url matches a regex pattern
 ```javascript
 history({
   rewrites: [
-    { pattern: '/soccer', target: '/soccer.html'},
-    { pattern: '/tennis', target: '/tennis.html'},
+    { from: /\/soccer/, to: '/soccer.html'},
+    { from: /\/tennis/, to: '/tennis.html'}
+  ]
 });
 ```
 

diff --git a/lib/index.js b/lib/index.js
@@ -54,12 +54,12 @@ exports = module.exports = function historyApiFallback(options) {
     }
 
     var rewriteTarget = options.index || '/index.html';
+
     options.rewrites = options.rewrites || [];
-    for (var i in options.rewrites) {
-      var rewrite = options.rewrites[i],
-        pattern = new RegExp(rewrite.pattern);
-      if (parsedUrl.pathname.match(pattern) !== null) {
-        rewriteTarget = rewrite.target;
+    for (var i = 0; i < options.rewrites.length; i++) {
+      var rewrite = options.rewrites[i];
+      if (rewrite.from.test(parsedUrl.pathname)) {
+        rewriteTarget = rewrite.to;
       }
     }