Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing/Adding example for p2p_discovery #11

Closed
Huy-Nguyen-web opened this issue Aug 4, 2022 · 1 comment
Closed

Fixing/Adding example for p2p_discovery #11

Huy-Nguyen-web opened this issue Aug 4, 2022 · 1 comment

Comments

@Huy-Nguyen-web
Copy link

Hi, I've noticed that DefNet had a breaking change since the version 6.0.0, and that also create some issues to the p2p_discovery example.

When running the p2p_discovery example, after the client found a host, the logo instead of doing the animation, it's flying up through the screen.

My suggestion is to add self.p2p.stop in the current example, and create a new example without the stop function after the client found a server, so that people can decide whether or not they need to use the stop function in their project (or in which scenario that they might need).

@britzl britzl closed this as completed in e831cf2 Aug 7, 2022
@britzl
Copy link
Owner

britzl commented Aug 7, 2022

Thanks. I opted for simply stopping discovery at that point. I think that is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants