Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top displays full command #113

Closed
JPFrancoia opened this issue Jul 12, 2015 · 4 comments
Closed

top displays full command #113

JPFrancoia opened this issue Jul 12, 2015 · 4 comments

Comments

@JPFrancoia
Copy link

Hi,

Since version 1.10.0-2, the "top" variable in Conky displays full commands names. Before, if Deluge was running for example, I had the deluged process written like "deluged".

Now, I have "/usr/bin/python2 /usr/bin/deluged --port=54566 --config=/home/me/.config/deluge".

I think it's too verbose.

Do you know how to come back to the last format ? Downgrading to 1.9 branch solved the issue.

Sincerely

@marcpayne
Copy link
Contributor

I agree that it's too verbose now, although there are cases where it might be useful to see the full command line (e.g. for applications that use multiple processes, or Java-based programs).

Unfortunately, I don't see any way to revert to the old format. I propose having two options: name and name_short. Alternatively, to avoid changing the behavior of old configs, default to short names and have a name_long option (or name_verbose).

If I have the time, I will look into how the top feature is implemented and try to add an extra option. No guarantees, though, since I'm more of an interested user than a developer. If I can't handle the task, I'll report back.

@arclance
Copy link

Don't remove the new full length option I like it.
I have a way to toggle how much is shown since my whole conky has been in Lua for years.

@JPFrancoia
Copy link
Author

Yes as the work is done, having the possibility to choose between a short and long version is a good idea. However, it changes the old behavior, so a note in the changelog would have been great, and a default option set to name_short, as @marcpayne suggested, would have been a good idea too.

marcpayne added a commit to marcpayne/conky that referenced this issue Jul 20, 2015
Since commit 749083a, the output of ${top name <num>} contains the full
command line of each process, including arguments. While this feature can
be very useful, it changes the default behavior of Conky.

The present commit adds a new top_name_verbose option that allows the user
to toggle between basenames with no arguments (the old behavior) and full
command lines with arguments. To remain consistent with past versions of
Conky, the default value of top_name_verbose is false.

Fixes brndnmtthws#113 (brndnmtthws#113).
@JPFrancoia
Copy link
Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants