colours: cache X11 pixel values #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that we allocate these as-needed when converting colours to the X11 representation, we need to avoid reallocating the same colour over and over; cache them so we only allocate each colour once
✅ Deploy Preview for conkyweb canceled.
|
brndnmtthws
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442.
Checklist
doc/has been updatedDescription
This adds an
unordered_mapkeeping track of the X11 pixel values for X11 colors we've allocated. The original design allocated X11 colors at parsing time and represented colors with pixel values everywhere. Now that we represent colors in a backend-independent way, we allocate X11 colors when we set the color in the backend. This means that we reallocate colors every time we draw, which creates a leak of X resources that the server has to track. To avoid this, we can simply cache the X11 pixel values we create, fixing the observed performance regression and server-side memory growth.I tested this under XWayland against the conkyrc from #1442, after modifying the update_interval from 1.0 to 0.01 in order to speed up the resource leak. I first reproduced the memory leak and then verified that it no longer occurs with this patch.