ncurses color fixes #1482
Merged
ncurses color fixes #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2023 02:13
…aphical output are enabled
we previously used the ncurses color as the id for its color pair, but this scheme needs to be shifted by one to avoid using the invalid 0 color-pair id for black (color id 0)
✅ Deploy Preview for conkyweb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brndnmtthws
approved these changes
Mar 31, 2023
simotek
pushed a commit
to simotek/conky
that referenced
this pull request
Apr 5, 2023
* specials: avoid duplicating color specials when both ncurses and a graphical output are enabled * ncurses: fix black we previously used the ncurses color as the id for its color pair, but this scheme needs to be shifted by one to avoid using the invalid 0 color-pair id for black (color id 0) --------- Co-authored-by: bi4k8 <bi4k8@github>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple bugs with ncurses display backend.
The first is that when both ncurses and a graphical backend are enabled at the same time, they each cause one "special" to be emitted for
${color}objects, causing colors to be visually "doubled", e.g. lasting two lines of text instead of one. Instead, only emit a single special in the condition that ncurses or a graphical backend is enabled.The second is that d51bf68 mistakenly assumed that it was valid to call
init_pairwith a first argument of any ncurses color ID. In fact, the first argument ofinit_pairis a pair ID, and pair ID 0 is reserved; this contrasts with 0 as a color ID, which is black. To fix using black, use pair IDs offset by one from the corresponding color ID.Checklist
doc/has been updated