Fix memory leaks in X11 display backend #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conkyweb canceled.
|
FcFini() was never being called, which meant FontConfig did not clean up its internal storage. furthermore, restore a commented-out call to XftFontClose() 9acf0bb commented this call out, but it does not seem to cause any problems now on reload now
brndnmtthws
approved these changes
Mar 31, 2023
brndnmtthws
reviewed
Mar 31, 2023
| @@ -603,6 +603,9 @@ void display_output_x11::cleanup() { | |||
| XDestroyRegion(x11_stuff.region); | |||
| x11_stuff.region = nullptr; | |||
| } | |||
| #ifdef BUILD_XFT | |||
| FcFini(); | |||
There was a problem hiding this comment.
This function comes from fontconfig, rather than Xft, which is fine but we currently don't do the necessary platform checks for fontconfig (which I assume is why the build fails on macos).
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions
bot
added
gh-actions
github-actions
bot
removed
gh-actions
simotek
pushed a commit
to simotek/conky
that referenced
this pull request
Apr 5, 2023
* display-x11: fix memory leaks FcFini() was never being called, which meant FontConfig did not clean up its internal storage. furthermore, restore a commented-out call to XftFontClose() 9acf0bb commented this call out, but it does not seem to cause any problems now on reload now * feat: Move docs to website, rearrange bits (brndnmtthws#1475) * build(deps): bump actions/stale from 7 to 8 (brndnmtthws#1472) Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add fontconfig platform checks --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bi4k8 <bi4k8@github> Co-authored-by: Brenden Matthews <brenden@brndn.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brenden Matthews <github@brenden.brndn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not ongoing leaks but just missing cleanup that offends
valgrind. One of these destructors was previously associated with crashes, but I believe the cases where it would crash no longer apply.Checklist
doc/has been updated