Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top: do not print ${top mem 1} as inf if $mem not used #1518

Merged
merged 1 commit into from
May 5, 2023

Conversation

bi4k8
Copy link
Collaborator

@bi4k8 bi4k8 commented Apr 26, 2023

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • [n/a] Documentation in doc/ has been updated
  • All new code is licensed under GPLv3

Description

This adds a call to update_meminfo() before attempting to update top processes, because they depend on the meminfo being sane. This fixes issue #960.

Tested with the below conkyrc:

conky.config = { 
    out_to_console = true,
    out_to_x = false,
    update_interval = 1,
} 
 
conky.text = [[
${color grey}Name              PID   CPU%   MEM%
${color lightgrey} ${top name 1} ${top pid 1} ${top cpu 1} ${top mem 1}
]]

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 405c9f8
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/64497fc06ff7650008ed93a7

@github-actions github-actions bot added the sources PR modifies project sources label Apr 26, 2023
@bi4k8 bi4k8 merged commit 7fa3d11 into brndnmtthws:main May 5, 2023
@bi4k8 bi4k8 deleted the top-mem-percent branch May 5, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants