Clean up error handling #1524
Merged
Clean up error handling #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 5, 2023 00:42
there's no need to call calloc() for 16B, nor do we need to error-handle that allocation with exit()
this behavior was already present for the status variables but not others
this also fixes the segfault that would happen in the main loop after `clean_up_without_threads` (brndnmtthws#945)
this lets us simplify error handling
it's surprising to pass 2 nullptr arguments at most of the callsites of a logging function, so instead let callers explicitly state whether they have auxiliary data to free
✅ Deploy Preview for conkyweb canceled.
|
brndnmtthws
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/has been updatedDescription
This fixes error handling in i8k (#945) and freebsd
get_freq. Both would abort in cases they didn't need to, and the freebsd code can actually be made infallible. This also refactors a few cleanup and logging functions to simplify code around the program.Conky will no longer segfault or exit when i8k variables fail to open
/proc/i8k. Behavior is otherwise unchanged.Tested with the conkyrc from #945.