X11: Fix infinite loops caused by propagated Expose events #1725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/
has been updatedDescription
Fixes two issues introduced with the X11 Expose event propagation in commit a4ac632, as described in issue #1698:
own_window
is off caused by conky propagating the event to itself.I couldn't find any documentation saying Expose events should be propagated, so this fix simply stops propagation of the Expose event, just like it was handled by conky before the commit. There wasn't a specific issue that was fixed by this change in the original PR (propagation was added for input events, Expose events were being propagated alongside them), so I believe this will not introduce a regression.
I've tested this in both xfce and herbstluftwm, and both with picom running as compositor with
own_window yes
, and no compositor running withown_window no
. No infinite loop occurs in any of these cases, and conky is drawn as expected.