Lua imlib2 fixes #1729
Lua imlib2 fixes #1729
Conversation
github-actions
bot
added
the
documentation
✅ Deploy Preview for conkyweb canceled.
|
There was a problem hiding this comment.
This is a good start, but can you use the logging functions from logging.h instead of printf? I think NORM_ERR should do what you need.
brndnmtthws
added
bug
|
To make this really usable for my use case I suspect i'll have one more feature commit to add to this PR later today but as this stands hopefully it is an improvement on the existing codebase. |
|
I've added one more function |
|
@brndnmtthws I have no idea why |
Yeah that's odd, let me see if I can figure it out. |
|
|
Each of the following cases cause large numbers of cryptic imlib2 prints, so detect them and print a single error for each.
Previously if the source image was a different to the displayed image the alpha channel was incorrect, as it wasn't scaled leading to a series of artifacts.
Unfortunately we can't use logging.h directly from conky as its in C++ and lua bindings only have access to a C compiler. Instead we now have a very simple C implementation of logging.h to use within the bindings. This change also adds NULL checks to catch some extra invalid states
In some cases you are already working with a cairo_t and know your destination image size, this adds an API that allows you to handle these cases more easily. Along with now being able to draw images with an alpha level. It also leaves the original API unchanged.
Along with some other minor merge / C++ fixes.`
Co-authored-by: Brenden Matthews <github@brenden.brndn.io>
brndnmtthws
force-pushed
the
lua-imlib2-fixes
branch
from
3c865bf
to
745df42
Compare
Checklist
doc/has been updatedDescription
A range of fixes for the cairo_imlib2 lua helper, after using it for a couple of days
1. Significantly improve error reporting
Previously if you had an error in your code you would get an error message for each call to imlib2 which lead to alot of spam. Instead we now detect and print our own error message for common errors then return to help with this.
2. Implement Stride in a standard way
This doesn't actually fix anything but I noticed it could be improved when I was debugging something else.
3. Scale Alpha masks correctly.
We weren't scaling the output of the alpha mask to the size of the image we were displaying, which lead to the ugly artifacts that can be seen below. (Ignore the general incompleteness of the actual config its half done)
** Broken Image: **
** Fixed Image: **
4. Add Docs
Adds similar docs to the one's being worked on for cairo-text-helper