Restore previous strut behavior #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sources
✅ Deploy Preview for conkyweb canceled.
|
Caellian
approved these changes
Jun 9, 2024
|
It makes more sense IMO to consume horizontal space first as it's almost always greater than vertical. I also didn't intend on changing default behavior. |
Caellian
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/has been updatedDescription
This PR reverts conky to its pre-1.20.2 strut behavior. Before that version, conky would prefer to use vertical struts over horizontal struts (e.g. when placed in the top-left corner, conky would use the top strut instead of the left strut). PR #1849 changed this to prefer horizontal struts.
In the future it may be useful to allow the user to specify the strut direction, but for now I believe the best course of action is to restore the previous behavior ASAP.